chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

Use light/dark mode colors for image description text (#3003)

Browse source 
* Use light/dark mode colors for image description text

This is an accessibility issue -- in light mode (which should have dark text
on a light background) the text color was hardcoded to light grey and the
background color was a semi-transparent black.

Fixes https://github.com/tuskyapp/Tusky/issues/2983.

* Update app/src/main/res/drawable/ic_drag_indicator_horiz_24dp.xml

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
This commit is contained in:
Nik Clayton 2022-12-06 20:24:26 +01:00 committed by GitHub
parent 0d962c7cc1
commit 08642d7bdb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/res/drawable/description_bg_expanded.xml
View file

@ -4,7 +4,7 @@
android:topLeftRadius="6dp" android:topLeftRadius="6dp"
android:topRightRadius="6dp" /> android:topRightRadius="6dp" />
<stroke <stroke
android:color="?attr/colorBackgroundAccent" android:color="?attr/colorOutline"
android:width="1dp" /> android:width="1dp" />
<solid android:color="#B3000000" /> <solid android:color="?attr/colorSurface" />
</shape> </shape>

2
app/src/main/res/drawable/ic_drag_indicator_horiz_24dp.xml
View file

@ -4,6 +4,6 @@
<size <size
android:width="8dp" android:width="8dp"
android:height="1dp" /> android:height="1dp" />
<solid android:color="?attr/colorBackgroundAccent" /> <solid android:color="?android:textColorTertiary" />
<corners android:radius="1dp" /> <corners android:radius="1dp" />
</shape> </shape>

2
app/src/main/res/layout/fragment_view_image.xml
View file

@ -70,7 +70,7 @@
android:paddingRight="8dp" android:paddingRight="8dp"
android:paddingBottom="8dp" android:paddingBottom="8dp"
android:textAlignment="center" android:textAlignment="center"
android:textColor="#eee" android:textColor="?android:textColorPrimary"
android:textSize="?attr/status_text_medium" android:textSize="?attr/status_text_medium"
tools:text="Some media description which might get quite long so that it won't easily fit in one line" /> tools:text="Some media description which might get quite long so that it won't easily fit in one line" />
</androidx.core.widget.NestedScrollView> </androidx.core.widget.NestedScrollView>