chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

Add a description to the focus dialog (#2711)

Browse source 
* Show explanation atop focus set dialog

* Update app/src/main/res/layout/dialog_focus.xml

Per Connyduck suggestion

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
This commit is contained in:
mcclure 2022-10-15 13:04:27 -04:00 committed by GitHub
parent 9dd3a3d79b
commit 0e892be48e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
app/src/main/res/layout/dialog_focus.xml
View file

@ -1,7 +1,23 @@
<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent">
android:layout_height="match_parent"
android:orientation="vertical">
<TextView
android:id="@+id/focusExplanation"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:padding="24dp"
android:gravity="center"
android:textSize="18sp"
android:text="@string/set_focus_description" />
<FrameLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:id="@+id/imageContainer">
<!-- todo add padding -->
<ImageView
@ -14,4 +30,6 @@
android:layout_width="match_parent"
android:layout_height="match_parent" />
</FrameLayout>
</FrameLayout>
</LinearLayout>

1
app/src/main/res/values/strings.xml
View file

@ -408,6 +408,7 @@
<plurals name="hint_describe_for_visually_impaired">
<item quantity="other">Describe for visually impaired\n(%d character limit)</item>
</plurals>
<string name="set_focus_description">Tap or drag the circle to choose the focal point which will always be visible in thumbnails.</string>
<string name="action_set_caption">Set caption</string>
<string name="action_set_focus">Set focus point</string>
<string name="action_edit_image">Edit image</string>