chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

Fixes an intermittent null pointer exception caused by getActivity() returning null in callbacks.

Browse source
This commit is contained in:
Vavassor 2017-07-18 23:34:07 -04:00
parent 51e2b7c949
commit 30d7f269de
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/com/keylesspalace/tusky/ViewMediaActivity.java
View file

@ -147,6 +147,11 @@ public class ViewMediaActivity extends BaseActivity implements ViewMediaFragment
return true;
}
@Override
public void onBringUp() {
supportStartPostponedEnterTransition();
}
@Override
public void onDismiss() {
supportFinishAfterTransition();

8
app/src/main/java/com/keylesspalace/tusky/fragment/ViewMediaFragment.java
View file

@ -35,8 +35,8 @@ import com.squareup.picasso.Picasso;
public class ViewMediaFragment extends BaseFragment {
public interface PhotoActionsListener {
void onBringUp();
void onDismiss();
void onPhotoTap();
}
@ -45,7 +45,6 @@ public class ViewMediaFragment extends BaseFragment {
View rootView;
PhotoView photoView;
private static final String ARG_URL = "url";
private static final String ARG_START_POSTPONED_TRANSITION = "startPostponedTransition";
public static ViewMediaFragment newInstance(String url, boolean shouldStartPostponedTransition) {
@ -141,7 +140,8 @@ public class ViewMediaFragment extends BaseFragment {
public void onError() {
// if there's no image in cache, load from network and start trnasition
// immediately.
getActivity().supportStartPostponedEnterTransition();
photoActionsListener.onBringUp();
loadImageFromNetwork(url, photoView);
}
});
@ -173,6 +173,6 @@ public class ViewMediaFragment extends BaseFragment {
private void finishLoadingSuccessfully() {
rootView.findViewById(R.id.view_media_progress).setVisibility(View.GONE);
attacher.update();
getActivity().supportStartPostponedEnterTransition();
photoActionsListener.onBringUp();
}
}