move Html parsing to ViewData (#2414)

* move Html parsing to ViewData

* refactor reports to use viewdata

* cleanup code

* refactor conversations

* fix getEditableText

* rename StatusParsingHelper

* fix tests

* commit db schema file

* add file header

* rename helper function to parseAsMastodonHtml

* order imports correctly

* move mapping off main thread to default dispatcher

* fix ktlint

app/src/main/java/com/keylesspalace/tusky/util/StatusParsingHelper.kt

@@ -0,0 +1,62 @@
+/* Copyright 2022 Tusky Contributors
+ *
+ * This file is a part of Tusky.
+ *
+ * This program is free software; you can redistribute it and/or modify it under the terms of the
+ * GNU General Public License as published by the Free Software Foundation; either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * Tusky is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even
+ * the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General
+ * Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along with Tusky; if not,
+ * see <http://www.gnu.org/licenses>. */
+
+package com.keylesspalace.tusky.util
+
+import android.text.SpannableStringBuilder
+import android.text.Spanned
+import androidx.core.text.parseAsHtml
+
+/**
+ * parse a String containing html from the Mastodon api to Spanned
+ */
+fun String.parseAsMastodonHtml(): Spanned {
+    return this.replace("<br> ", "<br>&nbsp;")
+        .replace("<br /> ", "<br />&nbsp;")
+        .replace("<br/> ", "<br/>&nbsp;")
+        .replace("  ", "&nbsp;&nbsp;")
+        .parseAsHtml()
+        /* Html.fromHtml returns trailing whitespace if the html ends in a </p> tag, which
+         * most status contents do, so it should be trimmed. */
+        .trimTrailingWhitespace()
+}
+
+fun replaceCrashingCharacters(content: Spanned): Spanned {
+    return replaceCrashingCharacters(content as CharSequence) as Spanned
+}
+
+fun replaceCrashingCharacters(content: CharSequence): CharSequence? {
+    var replacing = false
+    var builder: SpannableStringBuilder? = null
+    val length = content.length
+    for (index in 0 until length) {
+        val character = content[index]
+
+        // If there are more than one or two, switch to a map
+        if (character == SOFT_HYPHEN) {
+            if (!replacing) {
+                replacing = true
+                builder = SpannableStringBuilder(content, 0, index)
+            }
+            builder!!.append(ASCII_HYPHEN)
+        } else if (replacing) {
+            builder!!.append(character)
+        }
+    }
+    return if (replacing) builder else content
+}
+
+private const val SOFT_HYPHEN = '\u00ad'
+private const val ASCII_HYPHEN = '-'

app/src/main/java/com/keylesspalace/tusky/util/ViewDataUtils.kt

@@ -27,12 +27,9 @@ fun Status.toViewData(
     isExpanded: Boolean,
     isCollapsed: Boolean
 ): StatusViewData.Concrete {
-    val visibleStatus = this.reblog ?: this
-
     return StatusViewData.Concrete(
         status = this,
         isShowingContent = isShowingContent,
-        isCollapsible = shouldTrimStatus(visibleStatus.content),
         isCollapsed = isCollapsed,
         isExpanded = isExpanded,
     )