chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

Fix sending wrong requests for autocompletion (#414)

Browse source 
The problem was that Tusky kept sending requests for autocompletion
while writing toots even when the user wasn't typing a username
anymore. As it happened very often we would exceed the API request
limit and user wouldn't be able to send the toot.

This happened because Tokenizer is not used as expected. In fact,
during testing, findTokenEnd() and terminateToken() were never called.
I've tried setting a Validator but it wasn't used either. I'm not
sure what is the reason.

I am afraid it still may work incorrectly for the full nicknames
(ones with the instance name, like @name@isntance) because
the search may happen for the instance name but it's not as
critical.
This commit is contained in:
Ivan Kupalov 2017-10-25 01:02:38 +04:00 committed by Konrad Pozniak
parent 3054980d74
commit 4736462911
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/src/main/java/com/keylesspalace/tusky/util/MentionTokenizer.java
View file

@ -25,6 +25,7 @@ public class MentionTokenizer implements MultiAutoCompleteTextView.Tokenizer {
public int findTokenStart(CharSequence text, int cursor) { public int findTokenStart(CharSequence text, int cursor) {
int i = cursor; int i = cursor;
while (i > 0 && text.charAt(i - 1) != '@') { while (i > 0 && text.charAt(i - 1) != '@') {
if (!Character.isLetterOrDigit(text.charAt(i - 1))) return cursor;
i--; i--;
} }
if (i < 1 || text.charAt(i - 1) != '@') { if (i < 1 || text.charAt(i - 1) != '@') {