chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

fix vanishing toots bug when refreshing (#1343)

Browse source
This commit is contained in:
Konrad Pozniak 2019-06-24 21:43:14 +02:00 committed by GitHub
parent ac2e16e08c
commit 56b53c458a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
app/src/main/java/com/keylesspalace/tusky/fragment/TimelineFragment.java
View file

@ -284,6 +284,7 @@ public class TimelineFragment extends SFragment implements
}
this.updateCurrent();
this.loadAbove();
});
}
@ -292,7 +293,7 @@ public class TimelineFragment extends SFragment implements
if (this.statuses.isEmpty()) {
topId = null;
} else {
topId = CollectionsKt.first(statuses, Either::isRight).asRight().getId();
topId = CollectionsKt.first(this.statuses, Either::isRight).asRight().getId();
}
this.timelineRepo.getStatuses(topId, null, null, LOAD_AT_ONCE,
TimelineRequestMode.NETWORK)
@ -305,22 +306,32 @@ public class TimelineFragment extends SFragment implements
if (!statuses.isEmpty()) {
filterStatuses(statuses);
// Working around a bug when Mastodon API doesn't return the first
// status because of string "id < maxId". Hacking with ID doesn't
// help.
if (!this.statuses.isEmpty()) {
Either<Placeholder, Status> firstOld = this.statuses.get(0);
this.statuses.clear();
this.statuses.add(firstOld);
} else {
this.statuses.clear();
if (!this.statuses.isEmpty() && topId != null) {
// clear old cached statuses
Iterator<Either<Placeholder, Status>> iterator = statuses.iterator();
while (iterator.hasNext()) {
Either<Placeholder, Status> item = iterator.next();
if(item.isRight()) {
Status status = item.asRight();
if (status.getId().length() < topId.length() || status.getId().compareTo(topId) <= 0) {
iterator.remove();
}
} else {
Placeholder placeholder = item.asLeft();
if (placeholder.getId().length() < topId.length() || placeholder.getId().compareTo(topId) <= 0) {
iterator.remove();
}
}
}
}
this.statuses.addAll(statuses);
this.updateAdapter();
}
this.bottomLoading = false;
// Get more statuses so that users know that something is there
this.loadAbove();
},
(e) -> {
this.initialUpdateFailed = true;
@ -557,9 +568,10 @@ public class TimelineFragment extends SFragment implements
isNeedRefresh = false;
if (this.initialUpdateFailed) {
updateCurrent();
} else {
this.loadAbove();
}
this.loadAbove();
}
private void loadAbove() {
@ -1171,7 +1183,7 @@ public class TimelineFragment extends SFragment implements
private void removeConsecutivePlaceholders() {
for (int i = 0; i < statuses.size() - 1; i++) {
if (!statuses.get(i).isRight() && !statuses.get(i + 1).isRight()) {
if (statuses.get(i).isLeft() && statuses.get(i + 1).isLeft()) {
statuses.remove(i);
}
}
@ -1201,13 +1213,13 @@ public class TimelineFragment extends SFragment implements
* For certain requests we don't want to see placeholders, they will be removed some other way
*/
private void clearPlaceholdersForResponse(List<Either<Placeholder, Status>> statuses) {
CollectionsKt.removeAll(statuses, s -> !s.isRight());
CollectionsKt.removeAll(statuses, Either::isLeft);
}
private void replacePlaceholderWithStatuses(List<Either<Placeholder, Status>> newStatuses,
boolean fullFetch, int pos) {
Either<Placeholder, Status> placeholder = statuses.get(pos);
if (!placeholder.isRight()) {
if (placeholder.isLeft()) {
statuses.remove(pos);
}