Fix some warnings & recreate lint-baseline.xml (#4278)

app/src/main/java/com/keylesspalace/tusky/components/account/media/AccountMediaRemoteMediator.kt

@@ -59,7 +59,7 @@ class AccountMediaRemoteMediator(
             }
 
             val attachments = statuses.flatMap { status ->
-                AttachmentViewData.list(status, activeAccount.alwaysShowSensitiveMedia ?: false)
+                AttachmentViewData.list(status, activeAccount.alwaysShowSensitiveMedia)
             }
 
             if (loadType == LoadType.REFRESH) {

app/src/main/java/com/keylesspalace/tusky/components/account/media/AccountMediaViewModel.kt

@@ -27,7 +27,7 @@ import com.keylesspalace.tusky.viewdata.AttachmentViewData
 import javax.inject.Inject
 
 class AccountMediaViewModel @Inject constructor(
-    private val accountManager: AccountManager,
+    accountManager: AccountManager,
     api: MastodonApi
 ) : ViewModel() {
 

app/src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt

@@ -966,7 +966,7 @@ class ComposeActivity :
 
     private fun onMediaPick() {
         addMediaBehavior.addBottomSheetCallback(
-            object : BottomSheetBehavior.BottomSheetCallback() {
+            object : BottomSheetCallback() {
                 override fun onStateChanged(bottomSheet: View, newState: Int) {
                     // Wait until bottom sheet is not collapsed and show next screen after
                     if (newState == BottomSheetBehavior.STATE_COLLAPSED) {

app/src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt

@@ -54,7 +54,7 @@ class CaptionDialog : DialogFragment() {
         inflater: LayoutInflater,
         container: ViewGroup?,
         savedInstanceState: Bundle?
-    ) = inflater.inflate(R.layout.dialog_image_description, container, false)
+    ): View = inflater.inflate(R.layout.dialog_image_description, container, false)
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         val imageView = binding.imageDescriptionView

app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationFetcher.kt

@@ -41,7 +41,7 @@ data class Links(val next: String?, val prev: String?) {
  *
  * Should only be called by a worker thread.
  *
- * @see NotificationWorker
+ * @see com.keylesspalace.tusky.worker.NotificationWorker
  * @see <a href="https://developer.android.com/guide/background/persistent/threading/worker">Background worker</a>
  */
 @WorkerThread

app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsAdapter.kt

@@ -40,7 +40,6 @@ import org.xml.sax.XMLReader
 
 class ViewEditsAdapter(
     private val edits: List<StatusEdit>,
-    private val animateAvatars: Boolean,
     private val animateEmojis: Boolean,
     private val useBlurhash: Boolean,
     private val listener: LinkListener

app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsFragment.kt

@@ -135,7 +135,6 @@ class ViewEditsFragment :
 
                         binding.recyclerView.adapter = ViewEditsAdapter(
                             edits = uiState.edits,
-                            animateAvatars = animateAvatars,
                             animateEmojis = animateEmojis,
                             useBlurhash = useBlurhash,
                             listener = this@ViewEditsFragment