chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases 1 Activity

Small changes to the media player (#1572)

Browse source 
* Resolving some issues with media playback.

* Changing ViewVideoFragment so that it fully handles autohiding the
  media controller, allowing consistency between it and the toolbar

* Fixed an issue where the toolbar and description were not fading in

* Do not hide the toolbar/media player if the video is loading or paused

* Created "ExposedPlayPausedVideoView" to allow hooking play/pause

* Fix back button when viewing videos

* Back button did not work if video controls were visible.

* Tweak audio player

* Always show the controls when audio begins playing

* Do not auto-hide the controls if the player is playing audio

* Address PR comments

* Use overloaded constructor
* Remove m prefix

* Fix subtle media player issues

* Fix audio player incorrectly auto-hiding after hiding/showing toolbar

* Only subscribe touch listener once content is ready
  - Prevents top toolbar visibility from getting out of phase with audio player visibility if hidden during load
This commit is contained in:
Vivianne 2020-01-16 10:01:02 -08:00 • committed by Konrad Pozniak
commit a7c1345085
4 changed files with 93 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/res/layout/fragment_view_video.xml
View file

@ -23,7 +23,7 @@
app:layout_constraintTop_toTopOf="parent"
tools:text="Some media description" />
<VideoView
<com.keylesspalace.tusky.view.ExposedPlayPauseVideoView
android:id="@+id/videoView"
android:layout_width="wrap_content"
android:layout_height="match_parent"