chinwag/chinwag-android
chinwag/chinwag-android
2
0
Fork 0
Code Issues Pull requests Releases Activity

Convert TimelineFragment to Kotlin & ViewBinding (#2131)

Browse source 
* convert TimelineFragment to Kotlin

* cleanup some code

* migrate to viewbinding

* cleanup even more code

* address review feedback

* improve findStatusOrReblogPositionById
This commit is contained in:
Konrad Pozniak 2021-04-22 18:48:16 +02:00 committed by GitHub
parent eea8b53617
commit bf6d7a6b97
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 1268 additions and 1529 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/com/keylesspalace/tusky/fragment/SFragment.java
View file

@ -511,7 +511,7 @@ public abstract class SFragment extends Fragment implements Injectable {
}); });
} }
@VisibleForTesting @VisibleForTesting(otherwise = VisibleForTesting.PROTECTED)
public void reloadFilters(boolean forceRefresh) { public void reloadFilters(boolean forceRefresh) {
if (filters != null && !forceRefresh) { if (filters != null && !forceRefresh) {
applyFilters(forceRefresh); applyFilters(forceRefresh);
@ -547,7 +547,7 @@ public abstract class SFragment extends Fragment implements Injectable {
// Override to refresh your fragment // Override to refresh your fragment
} }
@VisibleForTesting @VisibleForTesting(otherwise = VisibleForTesting.PROTECTED)
public boolean shouldFilterStatus(Status status) { public boolean shouldFilterStatus(Status status) {
if (filterRemoveRegex && status.getPoll() != null) { if (filterRemoveRegex && status.getPoll() != null) {

1526
app/src/main/java/com/keylesspalace/tusky/fragment/TimelineFragment.java
View file

File diff suppressed because it is too large Load diff

1265
app/src/main/java/com/keylesspalace/tusky/fragment/TimelineFragment.kt Normal file
View file

File diff suppressed because it is too large Load diff

2
app/src/main/java/com/keylesspalace/tusky/util/ListStatusAccessibilityDelegate.kt
View file

@ -22,7 +22,7 @@ import com.keylesspalace.tusky.viewdata.StatusViewData
import kotlin.math.min import kotlin.math.min
// Not using lambdas because there's boxing of int then // Not using lambdas because there's boxing of int then
interface StatusProvider { fun interface StatusProvider {
fun getStatus(pos: Int): StatusViewData? fun getStatus(pos: Int): StatusViewData?
} }