Fix status diffing and improve timeline performance (#2386)

* fix status & account diffing

* introduce TimelineAccount

* use TimelineAccount where possible

* improve tests

* improve ConversationEntity equals/hashcode

* fix mistake in ConversationEntity

* improve StatusViewData comparison

* improve tests

* fix typo in comment

app/src/main/java/com/keylesspalace/tusky/adapter/AccountAdapter.kt

@@ -18,7 +18,7 @@ import android.view.LayoutInflater
 import android.view.ViewGroup
 import androidx.recyclerview.widget.RecyclerView
 import com.keylesspalace.tusky.R
-import com.keylesspalace.tusky.entity.Account
+import com.keylesspalace.tusky.entity.TimelineAccount
 import com.keylesspalace.tusky.interfaces.AccountActionListener
 import com.keylesspalace.tusky.util.removeDuplicates
 
@@ -28,7 +28,7 @@ abstract class AccountAdapter<AVH : RecyclerView.ViewHolder> internal constructo
     protected val animateAvatar: Boolean,
     protected val animateEmojis: Boolean
 ) : RecyclerView.Adapter<RecyclerView.ViewHolder?>() {
-    var accountList = mutableListOf<Account>()
+    var accountList = mutableListOf<TimelineAccount>()
     private var bottomLoading: Boolean = false
 
     override fun getItemCount(): Int {
@@ -73,12 +73,12 @@ abstract class AccountAdapter<AVH : RecyclerView.ViewHolder> internal constructo
         }
     }
 
-    fun update(newAccounts: List<Account>) {
+    fun update(newAccounts: List<TimelineAccount>) {
         accountList = removeDuplicates(newAccounts)
         notifyDataSetChanged()
     }
 
-    fun addItems(newAccounts: List<Account>) {
+    fun addItems(newAccounts: List<TimelineAccount>) {
         val end = accountList.size
         val last = accountList[end - 1]
         if (newAccounts.none { it.id == last.id }) {
@@ -100,7 +100,7 @@ abstract class AccountAdapter<AVH : RecyclerView.ViewHolder> internal constructo
         }
     }
 
-    fun removeItem(position: Int): Account? {
+    fun removeItem(position: Int): TimelineAccount? {
         if (position < 0 || position >= accountList.size) {
             return null
         }
@@ -109,7 +109,7 @@ abstract class AccountAdapter<AVH : RecyclerView.ViewHolder> internal constructo
         return account
     }
 
-    fun addItem(account: Account, position: Int) {
+    fun addItem(account: TimelineAccount, position: Int) {
         if (position < 0 || position > accountList.size) {
             return
         }

app/src/main/java/com/keylesspalace/tusky/adapter/AccountViewHolder.java

@@ -9,7 +9,7 @@ import androidx.preference.PreferenceManager;
 import androidx.recyclerview.widget.RecyclerView;
 
 import com.keylesspalace.tusky.R;
-import com.keylesspalace.tusky.entity.Account;
+import com.keylesspalace.tusky.entity.TimelineAccount;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.interfaces.LinkListener;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
@@ -33,7 +33,7 @@ public class AccountViewHolder extends RecyclerView.ViewHolder {
         showBotOverlay = sharedPrefs.getBoolean("showBotOverlay", true);
     }
 
-    public void setupWithAccount(Account account, boolean animateAvatar, boolean animateEmojis) {
+    public void setupWithAccount(TimelineAccount account, boolean animateAvatar, boolean animateEmojis) {
         accountId = account.getId();
         String format = username.getContext().getString(R.string.status_username_format);
         String formattedUsername = String.format(format, account.getUsername());

app/src/main/java/com/keylesspalace/tusky/adapter/BlocksAdapter.kt

@@ -22,7 +22,7 @@ import android.widget.ImageView
 import android.widget.TextView
 import androidx.recyclerview.widget.RecyclerView
 import com.keylesspalace.tusky.R
-import com.keylesspalace.tusky.entity.Account
+import com.keylesspalace.tusky.entity.TimelineAccount
 import com.keylesspalace.tusky.interfaces.AccountActionListener
 import com.keylesspalace.tusky.util.emojify
 import com.keylesspalace.tusky.util.loadAvatar
@@ -55,7 +55,7 @@ class BlocksAdapter(
         private val unblock: ImageButton = itemView.findViewById(R.id.blocked_user_unblock)
         private var id: String? = null
 
-        fun setupWithAccount(account: Account, animateAvatar: Boolean, animateEmojis: Boolean) {
+        fun setupWithAccount(account: TimelineAccount, animateAvatar: Boolean, animateEmojis: Boolean) {
             id = account.id
             val emojifiedName = account.name.emojify(account.emojis, displayName, animateEmojis)
             displayName.text = emojifiedName

app/src/main/java/com/keylesspalace/tusky/adapter/FollowRequestViewHolder.kt

@@ -22,7 +22,7 @@ import android.text.style.StyleSpan
 import androidx.recyclerview.widget.RecyclerView
 import com.keylesspalace.tusky.R
 import com.keylesspalace.tusky.databinding.ItemFollowRequestBinding
-import com.keylesspalace.tusky.entity.Account
+import com.keylesspalace.tusky.entity.TimelineAccount
 import com.keylesspalace.tusky.interfaces.AccountActionListener
 import com.keylesspalace.tusky.util.emojify
 import com.keylesspalace.tusky.util.loadAvatar
@@ -34,7 +34,7 @@ class FollowRequestViewHolder(
     private val showHeader: Boolean
 ) : RecyclerView.ViewHolder(binding.root) {
 
-    fun setupWithAccount(account: Account, animateAvatar: Boolean, animateEmojis: Boolean) {
+    fun setupWithAccount(account: TimelineAccount, animateAvatar: Boolean, animateEmojis: Boolean) {
         val wrappedName = account.name.unicodeWrap()
         val emojifiedName: CharSequence = wrappedName.emojify(account.emojis, itemView, animateEmojis)
         binding.displayNameTextView.text = emojifiedName

app/src/main/java/com/keylesspalace/tusky/adapter/MutesAdapter.kt

@@ -9,7 +9,7 @@ import android.widget.TextView
 import androidx.core.view.ViewCompat
 import androidx.recyclerview.widget.RecyclerView
 import com.keylesspalace.tusky.R
-import com.keylesspalace.tusky.entity.Account
+import com.keylesspalace.tusky.entity.TimelineAccount
 import com.keylesspalace.tusky.interfaces.AccountActionListener
 import com.keylesspalace.tusky.util.emojify
 import com.keylesspalace.tusky.util.loadAvatar
@@ -69,7 +69,7 @@ class MutesAdapter(
         private var notifications = false
 
         fun setupWithAccount(
-            account: Account,
+            account: TimelineAccount,
             mutingNotifications: Boolean?,
             animateAvatar: Boolean,
             animateEmojis: Boolean

app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java

@@ -40,10 +40,10 @@ import androidx.recyclerview.widget.RecyclerView;
 import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.databinding.ItemFollowRequestBinding;
-import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.entity.Emoji;
 import com.keylesspalace.tusky.entity.Notification;
 import com.keylesspalace.tusky.entity.Status;
+import com.keylesspalace.tusky.entity.TimelineAccount;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.interfaces.LinkListener;
 import com.keylesspalace.tusky.interfaces.StatusActionListener;
@@ -335,7 +335,7 @@ public class NotificationsAdapter extends RecyclerView.Adapter {
             this.statusDisplayOptions = statusDisplayOptions;
         }
 
-        void setMessage(Account account) {
+        void setMessage(TimelineAccount account) {
             Context context = message.getContext();
 
             String format = context.getString(R.string.notification_follow_format);