Commit graph

757 commits

Author SHA1 Message Date
Conny Duck
a2eb41900f fix RecentlyNonNull/Nullable warnings 2018-09-22 21:11:18 +02:00
HellPie
4759783d10 Add support for collapsible statuses when they exceed 500 characters (#825)
* Update Gradle plugin to work with Android Studio 3.3 Canary

Android Studio 3.1.4 Stable doesn't render layout previews in this project
for whatever reason. Switching to the latest 3.3 Canary release fixes the
issue without affecting Gradle scripts but requires the new Android Gradle
plugin to match the new Android Studio release.

This commit will be reverted once development on the feature is done.

* Update gradle build script to allow installing debug builds alongside store version

This will allow developers, testers, etc to work on Tusky will not having to worry
about overwriting, uninstalling, fiddling with a preinstalled application which would
mean having to login again every time the development cycle starts/finishes and
manually reinstalling the app.

* Add UI changes to support collapsing statuses

The button uses subtle styling to not be distracting like the CW button on the timeline
The button is toggleable, full width to match the status textbox hitbox width and also
is shorter to not be too intrusive between the status text and images, or the post below

* Update status data model to store whether the message has been collapsed

* Update status action listener to notify of collapsed state changing

Provide stubs in all implementing classes and mark as TODO the stubs that
require a proper implementation for the feature to work.

* Add implementation code to handle status collapse/expand in timeline

Code has not been added elsewhere to simplify testing.
Once the code will be considered stable it will be also included in other
status action listener implementers.

* Add preferences so that users can toggle the collapsing of long posts

This is currently limited to a simple toggle, it would be nice to implement
a more advanced UI to offer the user more control over the feature.

* Update Gradle plugin to work with latest Android Studio 3.3 Canary 8

Just like the other commit, this will be reverted once the feature is working.
I simply don't want to deal with what changes in my installation of Android
Studio 3.1.4 Stable which breaks the layout preview rendering.

* Update data models and utils for statuses to better handle collapsing

I forgot that data isn't available from the API and can't really be built
from scratch using existing data due to preferences.
A new, extra boolean should fix the issue.

* Fix search breaking due to newly introduced variables in utils classes

* Fix timeline breaking due to newly introduced variables in utils classes

* Fix item status text for collapsed toggle being shown in the wrong state

* Update timeline fragment to refresh the list when collapsed settings change

* Add support for status content collapse in timeline viewholder

* Fix view holder truncating posts using temporary debug settings at 50 chars

* Add toggle support to notification layout as well

* Add support for collapsed statuses to search results

* Add support for expandable content to notifications too

* Update codebase with some suggested changes by @charlang

* Update more code with more suggestions and move null-safety into view data

* Update even more code with even more suggested code changes

* Revert a0a41ca and 0ee004d (Android Studio 3.1 to Android Studio 3.3 updates)

* Add an input filter utility class to reuse code for trimming statuses

* Update UI of statuses to show a taller collapsible button

* Update notification fragment logging to simplify null checks

* Add smartness to SmartLengthInputFilter such as word trimming and runway

* Fix posts with show more button even if bad ratio didn't collapse

* Fix thread view showing button but not collapsing by implementing the feature

* Fix spannable losing spans when collapsed and restore length to 500 characters

* Remove debug build suffix as per request

* Fix all the merging happened in f66d689, 623cad2 and 7056ba5

* Fix notification button spanning full width rather than content width

* Add a way to access a singleton to smart filter and use clearer code

* Update view holders using smart input filters to use more singletons

* Fix code style lacking spaces before boolean checks in ifs and others

* Remove all code related to collapsibility preferences, strings included

* Update style to match content warning toggle button

* Update strings to give cleaner differentiation between CW and collapse

* Update smart filter code to use fully qualified names to avoid confusion
2018-09-19 19:51:20 +02:00
Gian Sass
bfea5119d5 sort custom emojis alphabetically (#853) 2018-09-18 20:46:50 +02:00
Conny Duck
17189216e3 remove fake shadow view and replace with elevation in AccountActivity 2018-09-16 19:46:06 +02:00
Konrad Pozniak
dbb3f4e826
update targetSdkVersion to 28 (#842)
* update targetSdkVersion to 28

* update robolectric to support api 28
2018-09-16 19:23:32 +02:00
Konrad Pozniak
4402f3d337
update minSdkVersion to 21 (#843)
* set minSdkVersion to 21

* use elevation instead of additional views for shadow

* clean up code occurrences

* remove drawable compat code

* remove no longer needed resources

* remove unneeded android:clipChildren="false"

* Revert "remove no longer needed resources"

This reverts commit 67a4d6f8d87b3f116b95d90dfb48f350d342f503.

* remove no longer needed resources (this time the right ones)
2018-09-16 18:54:12 +02:00
Conny Duck
5621e5d2d4 fix crash when trying to view account with invalid id
closes #848
2018-09-15 21:51:53 +02:00
Conny Duck
669153089a dont hold whole file content in memory when uploading media 2018-09-10 10:00:06 +02:00
Conny Duck
90ef078dd0 update media limits for Mastodon 2.5 2018-09-10 10:00:06 +02:00
Conny Duck
51d231834c Merge branch 'AbsoluteTime' of https://github.com/kyori19/Tusky into kyori19-AbsoluteTime
# Conflicts:
#	app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java
2018-09-09 21:48:01 +02:00
Conny Duck
2436099d35 fix links with uppercase letters in scheme not being opened
closes #801
2018-09-04 18:43:06 +02:00
Conny Duck
a57b354247 Merge remote-tracking branch 'origin/master' 2018-09-03 21:29:26 +02:00
Conny Duck
f72e08cae4 fix crash in notifications fragment, save account only when notificationid changed 2018-09-03 21:23:12 +02:00
Konrad Pozniak
aac63441d7
fix image preview rotation in ComposeActivity (#831) 2018-09-03 20:26:35 +02:00
Konrad Pozniak
0b3bee0d15
fix account switching when offline/error (#830) 2018-09-03 20:16:12 +02:00
Conny Duck
5131c44e93 fix empty message view showing/hiding at the wrong times 2018-09-02 13:23:36 +02:00
Konrad Pozniak
28c1c90a98
fix account list loading and clean up a lot of code (#823)
* fix account list loading and clean up a lot of code

* remove ACCESS_COARSE_LOCATION for API levels 23+

* small improvements
2018-08-31 21:52:09 +02:00
Conny Duck
ff4a8ff4b8 update deps 2018-08-31 20:40:40 +02:00
Conny Duck
cef4c6053d correctly hide the loading indicator when instance returns an error on login 2018-08-28 18:47:12 +02:00
Konrad Pozniak
b579a9baea
fix notification tab loading bottom notifications forever (#807) 2018-08-26 21:10:38 +02:00
Conny Duck
1d28f4728f fix crash in EditProfileViewModel 2018-08-26 12:41:26 +02:00
Conny Duck
a8bd468190 dont load header images in their full size 2018-08-24 23:13:28 +02:00
Conny Duck
1fef8c0c2b fix crash in NotificationsFragment when Preferences are first accessed
fixes #797
2018-08-24 19:47:27 +02:00
Conny Duck
8a1ac685c8 fix activity transitions (this time for real) 2018-08-23 21:06:49 +02:00
Levi Bard
bfb82bb10c Separate saved draft visibility from default reply visibility: #772 (#787) 2018-08-23 20:50:50 +02:00
Konrad Pozniak
e89f8cf3ee
wait for EmojiCompat to be initialized before using it (#791) 2018-08-23 20:44:25 +02:00
Konrad Pozniak
791a87e7a1
fix repeating toots in timelines (#789) 2018-08-22 21:19:56 +02:00
Konrad Pozniak
4653b1e37b
fix notification tab loading (#777)
* fix progressbars of footer and fragment overlapping

* add progressbar to bottom of notification list again

* fix bottom loading getting stuck sometimes
2018-08-22 21:18:56 +02:00
kyori
589188e27d Prevent creating new object in setCreatedAt 2018-08-20 22:51:30 +09:00
Konrad Pozniak
268ebb55f0 fix bug where addField button was enabled when it should not be
in EditProfileActivity
2018-08-20 14:49:23 +02:00
kyori
ad888854bc Use SimpleDateFormatter repeatedly. 2018-08-20 20:56:22 +09:00
kyori
4264fc42d6 Add process for when the createdAt is null. 2018-08-20 19:29:58 +09:00
kyori
b4bb80c4d5 Stop initializing String. 2018-08-20 17:47:19 +09:00
Konrad Pozniak
322a567e52 fix wrong activity transition of LoginActivity 2018-08-18 13:03:30 +02:00
Konrad Pozniak
7442f5bca8 fix bug where deleting profile field was not possible 2018-08-18 09:12:57 +02:00
kyori
219eafe6fc Prevent query SharedPreference in adapters. 2018-08-17 14:42:15 +09:00
kyori
6d1ec78984 Annotate on same line. 2018-08-17 10:21:55 +09:00
kyori
1d657a65a7 Show absolute time in Notifications tab 2018-08-16 23:10:21 +09:00
kyori
ca3a5791e3 Show absolute time 2018-08-16 22:51:23 +09:00
Konrad Pozniak
8930d277e6
add new elephant friends (#757)
* add new elephant friends

* add art license

* fix typo
2018-08-15 20:51:35 +02:00
Konrad Pozniak
04c842afc4
fix OOM crash when trying to caption large image (#756) 2018-08-15 20:47:36 +02:00
Konrad Pozniak
f022944e90
add possibility to change profile fields, refactor (#751)
* refactor EditProfileActivity, add profile fields

* preserve transparency when cropping profile images

* dont validate profile fields on client side

* revert unintentional change in card_frame_dark.xml

* improve activity_edit_profile layout for tablets

* Revert "improve activity_edit_profile layout for tablets"

This reverts commit 20ff3d167c39b15566e017108b33fe58690a8482.

* improve activity_edit_profile layout for tablets

* fix bug in EditProfileActivity, add snackbar

* improve EditProfileActivity code

* use events instead of shared prefs to communicate profile update
2018-08-15 20:47:09 +02:00
Conny Duck
b9e433c77f fix crash in ViewThreadFragment 2018-08-15 11:20:57 +02:00
Conny Duck
c38d2ad25e small improvements for MediaUtils 2018-08-15 11:06:54 +02:00
eleete0712
ef1fa0ca94 show CW in system notification for CW'd statuses (#754)
* show CW in system notification for CW'd statuses

* show spoiler text instead of generic CW message
2018-08-13 22:59:30 +02:00
Conny Duck
aa64a879f1 fix bug where unmuting would unmute wrong account 2018-08-12 20:19:44 +02:00
Conny Duck
ce7270cdb2 fix the activity transitions (again 🙄) 2018-08-07 23:08:53 +02:00
Conny Duck
9a42999451 improve activity slide in/out handling 2018-07-31 21:25:25 +02:00
Konrad Pozniak
9b422a97fe
Custom emojis in drawer (#737)
* upgrade MaterialDrawer

* improve CustomEmojiHelper so now any parent view can be used for invalidation

* cleanup MainActivity a bit

* add emojiList to account database and show compatEmojis and custom emojis in drawer

* improve perf of drawer profile update

* fix account switching

* reuse gson, break after profile item was found
2018-07-30 15:43:27 +02:00
Konrad Pozniak
b5a8915845
add possibility to view avatars fullscreen (#724)
* add possibility to view avatars fullscreen

* improve codestyle
2018-07-30 15:42:45 +02:00
Ivan Kupalov
133808891d Add RoundedImageView for avatars (#739)
* Add RoundedImageView for avatars

* RoundedImageView: Remove unused things, fix touchable area
2018-07-30 15:36:22 +02:00
qwazix
562beacfc1 Add black theme (#726)
* Add black theme

On amoled screens a completely black theme helps save battery,
besides looking awesome!

* Fix first set of merge request issues except the dialog.

* Black theme inherits from dark and only the different values
  are declared
* Make nav bar translucent (for some reason content does not
  go behind it in main activity. Need to investigate)
* Remove nav bar line
* Fix toolbar color

* Fix dialog issue with black theme.

Revert translucent navigation.

* Translations updated, as well as possible from online sources.

* Make login screen respect black theme
2018-07-30 15:31:35 +02:00
Ivan Kupalov
6fcb3cb495 Add image descriptions indicator (#697)
* Add image descriptions indicator. Closes #683

* Add bg for description indicator, change symbol

* Use icon for image description indicator
2018-07-30 15:20:53 +02:00
Konrad Pozniak
2a6f6c4092
work around crash on Android 8 (#731) 2018-07-26 23:31:20 +02:00
Konrad Pozniak
dbdc597207
fix bug where home timeline was never showing "load more" button (#729) 2018-07-25 21:50:09 +02:00
Konrad Pozniak
7f648b1acd
improve dependency injection (#723) 2018-07-23 21:59:10 +02:00
Konrad Pozniak
61f3f6c928
Improve media resizing (#722)
* improve MediaUtils.getImageThumbnail so it does not load the whole bitmap into memory

* load thumbnails in device specific sizes
2018-07-23 21:55:09 +02:00
Conny Duck
67f4479e86 fix some lint warnings, use kotlin view imports in ModalTimeLineActivity 2018-07-23 15:18:33 +02:00
Conny Duck
0102a4bd60 fix bug where revoking a follow request was not possible 2018-07-22 14:34:55 +02:00
Conny Duck
e67261f80d normalize domains before saving them to database 2018-07-17 22:05:46 +02:00
Konrad Pozniak
b887196c31 fix crash when opening profiles with default emojis selected 2018-07-14 21:36:47 +02:00
Konrad Pozniak
aa5eb9f99a
increase cache size & dont cache full size media (#710) 2018-07-14 17:12:57 +02:00
Conny Duck
6f179fccaa fix crash in TimelineFragment 2018-07-12 21:21:53 +02:00
Conny Duck
e56386ea84 fix bug where sending toot is not possible despite it being below character limit 2018-07-10 19:48:41 +02:00
Conny Duck
4df93c49cb fix crash in AccountMediaFragment (again) 2018-07-09 08:59:06 +02:00
Conny Duck
b7da5f7a29 fix another crash in ViewThreadFragment 2018-07-08 19:21:19 +02:00
Conny Duck
b82ab6bb4f fix custom emojis in mention autocomplete 2018-07-08 14:40:56 +02:00
Conny Duck
26529b19d5 fix crash in AccountMediaFragment 2018-07-08 11:41:08 +02:00
Conny Duck
67f90d050c fix crash in TimelineFragment 2018-07-08 10:16:19 +02:00
Conny Duck
b2c0ed69f6 fix crash in ViewThreadFragment 2018-07-07 12:09:15 +02:00
Conny Duck
ef9e931428 fix regex filter not affecting spoilertext 2018-07-05 21:59:38 +02:00
Conny Duck
c452b8f281 Merge branch 'master' of https://github.com/Vavassor/Tusky 2018-07-05 21:36:16 +02:00
Conny Duck
d900e1d8cd fix crash in TimelineFragment 2018-07-05 21:32:49 +02:00
Conny Duck
28940169c6 enable custom emoji fonts for all api levels again 2018-07-05 21:14:32 +02:00
Ivan Kupalov
8c20d5dd93 Fix crash on receiving event in timeline (#704) 2018-07-02 22:12:27 +02:00
Conny Duck
c10cc59a8a enable custom emojis in follow notifications 2018-07-01 15:57:26 +02:00
Conny Duck
1d8d1efb5b enable custom emojis in notification messages 2018-07-01 14:44:38 +02:00
Conny Duck
3410fad62c only disable emoji fonts on Lollipop and lower 2018-07-01 14:35:11 +02:00
Conny Duck
0930fab72b fix crash on old mastodon instances 2018-07-01 13:34:35 +02:00
Konrad Pozniak
030a201da6
disable emoji fonts on Android 5 (#698) 2018-07-01 10:18:00 +02:00
Konrad Pozniak
1c5df27f91
use ACTION_GET_CONTENT for media selection again, fix uri permissions (#695) 2018-06-28 22:22:29 +02:00
Conny Duck
77617ba9bf fix crash on timeline reloading 2018-06-25 18:20:45 +02:00
Conny Duck
b655985997 only reload timeline on pref change when necessary 2018-06-25 17:20:41 +02:00
Conny Duck
970551adee fix the emoji selection dialog 2018-06-25 16:23:43 +02:00
Conny Duck
50b0d1fb8d cleanup code 2018-06-25 14:49:00 +02:00
Conny Duck
3c685800d8 fix #650 notifications alerting multiple times 2018-06-25 14:08:36 +02:00
Konrad Pozniak
3c569c6ac9
add License activity (#689)
* convert AboutActivity to Kotlin, use BottomSheetActivity for account resolving

* improve AboutActivity

* new License activity

* fix filemojicompat url
2018-06-25 13:02:34 +02:00
Ivan Kupalov
570d7e3597 Do not scroll to top on timeline refresh (#681)
* Do not scroll to top on timeline refresh

* Use dp for shifting timeline
2018-06-24 10:53:19 +02:00
Konrad Pozniak
e8d1b16b39
improve custom emoji support (#687) 2018-06-24 09:53:23 +02:00
Konrad Pozniak
a42ce9b793
fix media resizing (#686)
* fix media resizing

* move exception catching out of method
2018-06-18 13:26:31 +02:00
Konrad Pozniak
63f9d99390
Account activity redesign (#662)
* Refactor-all-the-things version of the fix for issue #573

* Migrate SpanUtils to kotlin because why not

* Minimal fix for issue #573

* Add tests for compose spanning

* Clean up code suggestions

* Make FakeSpannable.getSpans implementation less awkward

* Add secondary validation pass for urls

* Address code review feedback

* Fixup type filtering in FakeSpannable again

* Make all mentions in compose activity use the default link color

* new layout for AccountActivity

* fix the light theme

* convert AccountActivity to Kotlin

* introduce AccountViewModel

* Merge branch 'master' into account-activity-redesign

# Conflicts:
#	app/src/main/java/com/keylesspalace/tusky/AccountActivity.java

* add Bot badge to profile

* parse custom emojis in usernames

* add possibility to cancel follow request

* add third tab on profiles

* add account fields to profile

* add support for moved accounts

* set click listener on account moved view

* fix tests

* use 24dp as statusbar size

* add ability to hide reblogs from followed accounts

* add button to edit own account to AccountActivity

* set toolbar top margin programmatically

* fix crash

* add shadow behind statusbar

* introduce ViewExtensions to clean up code

* move code out of offsetChangedListener for perf reasons

* clean up stuff

* add error handling

* improve type safety

* fix ConstraintLayout warning

* remove unneeded ressources

* fix event dispatching

* fix crash in event handling

* set correct emoji on title

* improve some things

* wrap follower/foillowing/status views
2018-06-18 13:26:18 +02:00
Ivan Kupalov
c450af7b0d Fix account media progress indicator (#684)
* Fix account media progress indicator

* Use Kotlin Android ext in AccountMediaFragment
2018-06-17 21:49:51 +02:00
Ivan Kupalov
7254a5d7d6 Add smaller and larger font options (fix #657) (#660)
* Add smaller and larger font options

* Fix test sizes, comment out translations
2018-06-07 22:19:39 +02:00
Paul
30856a2f82 Enable boosting of own private toots, closes #664 (#666) 2018-05-28 21:29:06 +02:00
Ivan Kupalov
3756a1fd20
Add EventHub, add fav, reblog events, improve timelines (#562)
* Add AppStore, add fav, reblog events

* Add events, add handling to Timeline

* Add event handling to Notifications

* Mostly finish events

* Fix unsubscribing

* Cleanup timeline

* Fix newStatusEvent in thread, fix deleteEvent

* Insert new toots only in specific timelines

* Add missing else

* Rename AppStore to EventHub

* Fix tests

* Use DiffUtils for timeline

* Fix empty timeline bug. Improve loading placeholder

* Fix AsyncListDiff, loading indicator, "load more"

* Timeline fixes & improvements.

Fix infinite loading. Remove spinner correctly.
Don't refresh timeline without need.
2018-05-27 11:22:12 +03:00
Levi Bard
3a8d96346b fix rtl unicode formatting (#659)
* Isolate usernames when formatting, to improve interaction of RTL usernames with LTR locales (and vice versa)

* Add bidirectionality safeguards in NotificationHelper

* Cache bidirectionality formatter instance in NotificationsAdapter
2018-05-24 19:00:17 +02:00
Levi Bard
7e1f5edeca Behave like Mastodon web ui and only count URLs as 23 characters when composing (#629)
* Refactor-all-the-things version of the fix for issue #573

* Migrate SpanUtils to kotlin because why not

* Minimal fix for issue #573

* Add tests for compose spanning

* Clean up code suggestions

* Make FakeSpannable.getSpans implementation less awkward

* Add secondary validation pass for urls

* Address code review feedback

* Fixup type filtering in FakeSpannable again

* Make all mentions in compose activity use the default link color
2018-05-16 19:14:26 +02:00
Conny Duck
41743b0dca fix crash in SearchFragment 2018-05-14 18:23:33 +02:00
Ivan Kupalov
23d84dfa66 Show image descriptions in gallery (#630)
* Add circleci

* Commit to maybe fix ci

* Suppress false positives in lint

* Disable linting for tests in ci

* Add image descriptions to gallery

* Fix test

* [CI] Attempt to fix OOM error

* [CI] Attempt to fix OOM error, 2

* Add option to open status from media

* fix theme issue

* increase linespacing on media description
2018-05-10 20:13:25 +02:00
Constantin A
1108652823 EmojiCompat support (#600)
* Add EmojiCompat

* EmojiCompat doesn' replace all emojis anymore

* This app should be now capable of loading a EmojiCompat-font located in a file somewhere inside the device's storage

* Should now replace all emojis

* Add EmojiCompat support to EditTextTyped

* Provide EmojiCompat fonts

* The app won't crash anymore when no emoji font is available.
Emoji font should now be located at [Private external app directory]/files/EmojiCompat.ttf

* Removed BundledEmojiCompat dependency

Since this EmojiCompat-implementation does not rely on BundledEmojiCompat, there's no reason to have it enabled.

* Update EditTextTyped.kt

Since connection isn't assigned to (I tried doing so), it can be declared final/val again.

* Update README.md

* Add some non-working emoji preferences

* Add a short font list for testing

* Finished implementation

* Add Twemoji to font list

* Update documentation, more comments

* Delete AssetEmojiCompat which is obsolete now

* Update the font list

* Update the font list

* Fix font list & add Exception handling for malformed JSON files (hopefully)

* More fixes. It should work now...

* Removed AssetEmojiCompat (again)

* Add most of the changes

* Improved the EmojiCompat dialog's style

* The font list is now based on a static layout without external files

* Re-add the real font URL for Twemoji

* Emoji-font captions are now translatable

* Removed one unused String (loading)

* Removed emoji fonts from this repo

* Applied changes from the PR change requests

* The correct emoji font will be selected after cancelling a change

* Add details on the EmojiCompat fonts available (not shown yet)

* Add licensing information on Twemoji and Blobmoji

* Reworked some strings

* Moved FileEmojiCompat to its own library

* Update FileEmojiCompat to the latest version (1.0.3)

* EmojiCompat bug should be fixed

* Better handling of failed downloads

* Removed one TODO

Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>

* Update emoji attribution strings

Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>

* Fixed some misspelled strings

Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>
2018-05-10 11:16:56 +02:00