Commit graph

1457 commits

Author SHA1 Message Date
Konrad Pozniak
40346ff304 fix multiline account field alignment 2018-12-29 18:37:12 +01:00
Konrad Pozniak
5e6a4ae93d fix radiobutton size in compose options 2018-12-29 00:02:29 +01:00
jchmrt
30df1cf403 Set image previews correctly according to their focal points (#899)
* Add serialization of the meta-data and focus objects

These objects are added in some attachments. This commit adds data
classes which are able to serialize these (partially) in preparation
for the ability to honour the focal point information in image
previews.

* Implement correctly honouring the focal point meta-data in previews

This commit adds code which ensures that the image previews of media
attachments to toots are correctly cropped to always show the focal
point of the image (if it is specified). It should not in any way
influence how previews of media without a focal point are shown.

To achieve the correct crop on the image a few components were
needed:

First of all we needed a way to influence how the image is cropped
into the ImageView. It turns out that the preferred way to do this is
by setting the ScaleType to MATRIX and adjusting the matrix of the
image as needed. This matrix allows us to scale and transform the
image in the way we need to make sure that the focal point is visible
within the view. For this purpose we have the FocalPointEnforcer which
can calculate and set the appropriate matrix on an ImageView as soon
as the image is loaded.

However a second problem is that we need to make sure that this matrix
is updated whenever the size of the ImageView changes. The size might
change for example because the orientation of the device changed from
portrait to landscape or vice versas, or for a number of other reasons
such as the screen being split vertically or something like that.

To be able to hook onto this event we need to create a new extended
version of the ImageView class, which we call
MediaPreviewImageView. This class behaves exactly the same as a normal
ImageView, however if the focalPointEnforcer of this view is set, then
it will call this enforcer to update the image matrix any time the
size is changed.

So this commit changes all media previews in the item_status.xml and
item_status_detailled.xml layout files to the new
MediaPreviewImageView class. Additionally in the code for loading the
images into the previews a new case is added which tests if there is a
focus attribute in the meta-data. If so it makes sure to create and
set the FocalPointEnforcer.

* Fix typos in documentation comment

"to" -> "too"

* Use static imports to remove clutter in FocalPointEnforcerTest

Instead of duplication Assert. in front of every assertEquals, simply
statically import it.

* Move the MetaData and Focus classes into the Attachment class

Since they are very strongly linked to the attachment class and are
themselves very small.

* Refactor the focal point handling code

- All the code modifying the actual members of the
  MediaPreviewImageView is now in this class itself. This class still
  uses the FocalPointUtil to calculate the new Matrix, but it now
  handles setting this new Matrix itself.

- The FocalPointEnforcer has been renamed to the FocalPointUtil to
  reflect that it only calculates the correct matrix, but doesn't set
  anything on the MediaPreviewImageView.

- The Matrix used to control the cropping of the
  MediaPreviewImageViews is now only allocated a single time per view
  instead of each time the view is resized. This is done by caching
  the Matrix and passing it to the FocalPointUtil to update on each
  resize.

* Only reallocate focalMatrix if it is not yet initialized

This helps prevent unnecessary allocations in the case where
setFocalPoint is called multiple times.

* Change checking of availability of objects to use != null

As pointed out, the 'is' keyword is meant for checking types, not for
checking non-nullness.

* Make updateFocalPointMatrix() return nothing

This makes it clearer that it actually mutates the matrix it is
given.

* Fix bug with transitions crashing the PhotoView

Due to the android transitions for some reason copying the scaletype
from the MediaPreviewImageView to the PhotoView during the transition,
the PhotoView would crash on pictures with a focal point, since
PhotoView doesn't support ScaleType.MATRIX.

This is solved by the workaround of overriding both the getScaleType
and setScaleType methods to ensure that we use the MATRIX type in the
preview and the center_crop type in the PhotoView.

Additionally this commit also makes sure to remove the focal point
when the MediaPreviewImageView is recycled.

* Fix bug in overriden getScaleType

Instead of simply returning the scaleType we need to return the
super.getScaleType() method, to avoid crashing.

* Merge changes from master

Mainly the migration to androidx.
2018-12-28 16:32:07 +01:00
Pellaeon Lin
675e90e508 Update zh-rTW translation (#930)
* Update zh-rTW translation

* Add missing translation

* Copy zh-rTW strings to HK and MO for now, per @connyduck 's request
https://github.com/tuskyapp/Tusky/pull/930#issuecomment-450240996

Note that this should not be the final solution, HK and MO should be
able to understand the TW variant, but they're still different.
2018-12-28 15:39:02 +01:00
Konrad Pozniak
cd6766c261
hide toot content TextView when its empty (#969) 2018-12-27 22:32:14 +01:00
Konrad Pozniak
c04bcc26d5 fix AccountActivity tabs on tablets 2018-12-27 22:31:42 +01:00
Konrad Pozniak
c869886c19
add the ability to see who faved or boosted a toot (#962)
* move reblog/fav count up in detailed status view and make them clickable

* use status object returned by api when reblogging/faving

* Reblogs -> Boosts

* add support for viewing who faved/reblogged a status

* add onShowReblogs/onShowFavs to listener, fix display bug

* remove unneeded icon from previous revision

* small code improvements

* fix liking/boosting toot with card
2018-12-27 09:48:24 +01:00
Mostafa Ahangarha
4864bb79d9 Improved Persian translation (#965)
I have made these two thing:

- Made several modification to make the existing translation improved
- Added missing stings
2018-12-25 20:07:20 +01:00
Mostafa Ahangarha
6cd7a1ab8e Improve RTL support (#964)
By making these changes, texts in relevant pages will appear currectly
in RTL layout.
2018-12-25 20:07:03 +01:00
Ivan Kupalov
bac15c42bd Export Room schemes (#963) 2018-12-25 20:06:28 +01:00
kyori19
c9ce380d7a Fix wrong visibility icon(tuskyapp#901) (#960) 2018-12-20 18:25:36 +01:00
Conny Duck
f26c1718c9 update deps 2018-12-18 22:05:33 +01:00
Conny Duck
e054edc69d remove more Kotlin null check methods from release bytecode 2018-12-17 23:36:59 +01:00
Conny Duck
c7f231419e fix weird resizing of ComposeActivity when emojis are loaded on tablets 2018-12-17 21:58:52 +01:00
Conny Duck
0beeeb0f70 fix inconsistent post_privacy_names strings in translations 2018-12-17 20:54:09 +01:00
Conny Duck
554099f79d improve dialog styling 2018-12-17 20:47:42 +01:00
Conny Duck
b92d66a5e9 exclude unneeded license files from apk 2018-12-17 19:08:32 +01:00
Conny Duck
dd8d2131f7 update proguard rules for okhttp 2018-12-17 16:01:35 +01:00
Konrad Pozniak
a445c12094
Upgrade to AndroidX, move to MaterialComponents theme (#953)
* upgrade to AndroidX, upgrade libraries

* move to MaterialComponents theme

* make sure the compose button looks good everywhere

* fix tollbar title/button alignment on tablet

* move to new material color theming, consolidate colors and themes

* fix build, fix imports

* set error on TextInputLayout instead of EditText

* fix imports, TootButton when

* improve snackbar style

* fix task description color
2018-12-17 15:25:35 +01:00
Mélanie Chauvel (ariasuni)
1c34d21a23 Display mentions toot hidden (#954)
* WIP: still display mentions when toot content is hidden

* WIP: still display mentions when toot content is hidden (2)

* Still display mentions when toot content is hidden (3)

* Factorize code for setting content and spoiler on a toot

* Factorize condition
2018-12-16 10:30:40 +01:00
Conny Duck
eb7b000cc1 fix crash when using quick compose tile 2018-12-13 22:29:12 +01:00
Conny Duck
8b00d421ef Release 52 2018-12-12 20:53:26 +01:00
Mélanie Chauvel (ariasuni)
5230bd29a6 Fix a lot of easy-to-fix warnings (#957) 2018-12-12 20:28:05 +01:00
Konrad Pozniak
72c0adae03
Update Readme.MD 2018-12-12 19:46:43 +01:00
Conny Duck
c3e5305fa2 fix another crash in ViewImageFragment 2018-12-12 19:37:18 +01:00
Conny Duck
a0c399e2cf fix crash in MediaUtils.getVideoThumbnail 2018-12-12 18:56:42 +01:00
Konrad Pozniak
73670b8576
Improve emoji picker accessibility (#944)
* set emoji shortcode as content description on ImageView

* hide bottom sheets on back press
2018-12-07 17:05:02 +01:00
nora
59257c7af4 Update CONTRIBUTING.md (#952)
* Update CONTRIBUTING.md

Opened this file out of pure random curiosity and noticed a little bug. Since Tusky got three themes, this file was not up to date anymore.

* Update CONTRIBUTING.md

Removed outdated mention of API level 21 since anything below that isn't supported anymore.
2018-12-06 22:40:14 +01:00
Conny Duck
073c673e6d fix crash in EditProfileActivity 2018-12-06 22:34:36 +01:00
Conny Duck
f87b87bea3 close drawer when clicking on own profile and adding account
closes #948
2018-12-05 22:37:04 +01:00
Conny Duck
aae72205c3 show correct username of author when sharing toot content
closes #918
2018-12-03 15:22:51 +01:00
Conny Duck
afaaafdace add option to copy link of own toot to "more" menu
closes #928
2018-12-03 12:04:27 +01:00
Konrad Pozniak
1413a1155b
remove unnecessary compat code (#932) 2018-12-03 11:22:57 +01:00
Konrad Pozniak
8d7f879a8f
add checkmark to verified links and better constraints to account fields (#922)
* add checkmark to verified links and better constraints to account fields

* address pr feedback
2018-12-03 11:02:28 +01:00
Ivan Kupalov
19783c5aed Apply suggestions for ProgressImageView (#942) 2018-12-03 11:02:07 +01:00
dadosch
5b196556e1 Fix Typo in german translation (#943) 2018-12-03 10:52:25 +01:00
zital
7787aef6a1 Basque: orro -> tut (#936)
* orro -> tut

* orro -> tut
2018-11-30 21:14:00 +01:00
Billy Brawner
95a656dc0a Add visibility icons to detail statuses (#901)
* Add visibility icons to statuses

* Remove visibility icons from timeline statuses

* Dynamically scale visibility icon according to timestamp font size

* Remove visibility icon selection logic from Status model

* Migrate visibility icon logic to StatusDetailedViewHolder

* Simplify/improve performance of visibility icon layout

* Use text size for visibility icon size (instead of view size)

* Remove unnecessary LayoutListener

* Remove unnecessary visibilityIcon check
2018-11-28 19:46:10 +01:00
Conny Duck
9627d73f68 fix NullPointerException in ViewImageFragment 2018-11-27 21:18:21 +01:00
Conny Duck
f185c9d379 fix crash in ComposeActivity when loading no Emojis 2018-11-27 21:07:15 +01:00
Conny Duck
fed52398a6 Release 51 2018-11-26 18:52:08 +01:00
Isak Holmström
2f4d507b29 [sv] New strings translated. (#931)
* Updated with new strings, added new translations for mute

* Changed from nsfw to sensitive content

* translating new strings ++extra fixes

* Add files via upload

* [sv] New strings translated
2018-11-26 18:31:53 +01:00
Conny Duck
f5ec6b1ef7 fix NullPointerException in ViewImageFragment 2018-11-25 20:16:38 +01:00
Unai Tolosa Pontesta
12ba4747d8 Added Basque translations (#926)
* Added Basque translations

* zital

* zital
2018-11-25 19:42:50 +01:00
INAGAKI Hiroshi
d89f7c66c6 l10n: update Japanese translation (#929)
Updated Japanese translations and removed unnecessary spaces.

Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
2018-11-25 19:41:45 +01:00
Conny Duck
91fe819688 Release 50 2018-11-19 16:39:49 +01:00
Sylke Vicious
ab7c438286 Updated italian translation (#925) 2018-11-19 15:51:58 +01:00
ButterflyOfFire
e61d27baa0 Update arabic translation (#923)
Update arabic translation.
2018-11-19 10:53:27 +01:00
ButterflyOfFire
ecd954de0d Update french translation (#924)
Update french translation.
2018-11-19 10:53:15 +01:00
Evgeny Petrov
557a0c9d5f RU: Added missing string (#921) 2018-11-18 13:17:24 +01:00