chinwag-android/app
Nik Clayton c36b243745
Show reblog/favourite confirmations as menus not dialogs (#3418)
* Show reblog/favourite confirmations as menus not dialogs

The previous code used dialogs and displayed the text of the status when
reblogging or favouriting.

This didn't work when the post just contained images, and other material
from the status (content warning, polls) was not shown either.

Fix this by displaying a popup menu instead. The status remains visible so
the user can clearly see what they're acting on.

In addition, this lays the groundwork for supporting a long-press menu
in the future to allow the user to reblog/favourite from a different
account.

Fixes https://github.com/tuskyapp/Tusky/issues/3308

* Revert the change that puts the menu immediately over the icon

Although this behavious is consistent with how the option menu works, I
decided that the risk of someone inadvertently double-tapping in the same
location, and the first tap opens the menu and the second tap confirms the
action was too great.

So now the menu appears either above or below the icon depending on space,
and the user has to tap in two slightly different spaces.

This is also consistent with the previous behaviour, where it's highly
unlikely that the confirm button on the dialog would have been directly
under the user's finger if they double-tapped.
2023-03-18 09:37:55 +01:00
..
schemas/com.keylesspalace.tusky.db.AppDatabase Support the mastodon 4 filter api (#3188) 2023-03-11 13:12:50 +01:00
src Show reblog/favourite confirmations as menus not dialogs (#3418) 2023-03-18 09:37:55 +01:00
build.gradle Enforce lint cleanliness when building (#3363) 2023-03-13 10:23:42 +01:00
getGitSha.gradle Previous attempt to fix git sha on non-git build broke git build. (#3322) 2023-02-16 20:20:52 +01:00
lint-baseline.xml Enforce lint cleanliness when building (#3363) 2023-03-13 10:23:42 +01:00
lint.xml Enforce lint cleanliness when building (#3363) 2023-03-13 10:23:42 +01:00
proguard-rules.pro Add extra proguard rules for OkHttp (#3350) 2023-02-25 21:40:13 +01:00