From 7d25f72b9fb5f2940b998579da00a11f8a65fb40 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Wed, 26 Oct 2022 13:00:43 +0200 Subject: [PATCH] Fix negatives values in search index causing queries to fail (#19464) --- app/services/account_search_service.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/services/account_search_service.rb b/app/services/account_search_service.rb index 35b2e05f5..de1dc7b8e 100644 --- a/app/services/account_search_service.rb +++ b/app/services/account_search_service.rb @@ -105,7 +105,7 @@ class AccountSearchService < BaseService { script_score: { script: { - source: "(doc['followers_count'].value + 0.0) / (doc['followers_count'].value + doc['following_count'].value + 1)", + source: "(Math.max(doc['followers_count'].value, 0) + 0.0) / (Math.max(doc['followers_count'].value, 0) + Math.max(doc['following_count'].value, 0) + 1)", }, }, } @@ -113,10 +113,10 @@ class AccountSearchService < BaseService def followers_score_function { - field_value_factor: { - field: 'followers_count', - modifier: 'log2p', - missing: 0, + script_score: { + script: { + source: "log2p(Math.max(doc['followers_count'].value, 0))", + }, }, } end