From 8e9e7d57d8db697f5bc595f2e98c7e7b716fe59a Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Mon, 18 Dec 2023 04:58:53 -0500 Subject: [PATCH] Opt out of `Rails/UnusedIgnoredColumns` cop (#28385) --- .rubocop.yml | 6 ++++++ .rubocop_todo.yml | 13 ------------- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 222160422..2da7e361c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -109,6 +109,12 @@ Rails/SkipsModelValidations: Exclude: - 'db/*migrate/**/*' +# Reason: We want to preserve the ability to migrate from arbitrary old versions, +# and cannot guarantee that every installation has run every migration as they upgrade. +# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsunusedignoredcolumns +Rails/UnusedIgnoredColumns: + Enabled: false + # Reason: Some single letter camel case files shouldn't be split # https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecfilepath RSpec/FilePath: diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b8b4895f5..2fa3a1ef6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -196,19 +196,6 @@ Rails/UniqueValidationWithoutIndex: - 'app/models/identity.rb' - 'app/models/webauthn_credential.rb' -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/UnusedIgnoredColumns: - Exclude: - - 'app/models/account.rb' - - 'app/models/account_stat.rb' - - 'app/models/admin/action_log.rb' - - 'app/models/custom_filter.rb' - - 'app/models/email_domain_block.rb' - - 'app/models/report.rb' - - 'app/models/status_edit.rb' - - 'app/models/user.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: exists, where