From d2514445e102a2b2ddb9ba638f67fcd8adf6a5af Mon Sep 17 00:00:00 2001 From: Shel R Date: Thu, 20 Apr 2017 12:20:40 -0400 Subject: [PATCH] Repair most egregious mistakes in onboarding modal (#1964) * Repair most egregious mistakes The deployed changes broke the pedagogy and curriculum built into the design of the onboarding modals, which had been reviewed and approved by various other contributors. While the changed layouts of the pages make some of the original decisions impossible to re-implement without substantial work, these changes should at least make the modals not outright terrible. The empty confusing description of Mastodon was replaced with an actual basic explanation of federation. The language was modified to be friendly and conversational again. Grammatical errors were fixed. The explanations of local and federated timelines were re-ordered to be in the direct that the menus go, top to bottom, and the sentence was re-added which explains that they are what "public timelines" refers to (since this phrasing is used elsewhere in the UI) and suggests the user use them to discover who to follow. A figure of the profile picture that lives above the compose box was padded to page two to serve as a landmark for less technically literate users to easily find the compose box and understand that the next page is moving upwards, so that they can find the search bar. Ideally, the elephant artwork should be either removed or replaced with something less depressing. Room should be made to point users at the notifications column's settings icon because "how do I turn off the notification noise" is one of the most asked questions of new users and those icons are not easily noticeable. This last part may be made obsolete if the settings UI is later re-worked. * Change copy This commit addresses copy change suggestions made in the PR discussion * Add periods to ends of sentences missing periods * Made "Home" "Federated" "Local" and "Notifications" lowercase * Separate explanation of "connecting" and the word "instance" into two sentences, to make the sentence less dense. --- .../ui/components/onboarding_modal.jsx | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/app/assets/javascripts/components/features/ui/components/onboarding_modal.jsx b/app/assets/javascripts/components/features/ui/components/onboarding_modal.jsx index e5c395119..36e0d0c8a 100644 --- a/app/assets/javascripts/components/features/ui/components/onboarding_modal.jsx +++ b/app/assets/javascripts/components/features/ui/components/onboarding_modal.jsx @@ -25,8 +25,8 @@ const PageOne = ({ acct, domain }) => (

-

-

{acct}@{domain} }}/>

+

+

{acct}@{domain} }}/>

); @@ -39,6 +39,9 @@ PageOne.propTypes = { const PageTwo = () => (
+
+ +
(
-

+

-

+

-
+
-
+
-

+

); @@ -128,7 +131,7 @@ const PageSix = ({ admin }) => {

@{admin.get('acct')} }} />
- }}/> + }}/>

); } @@ -138,7 +141,8 @@ const PageSix = ({ admin }) => {

{adminSection}

GitHub }} />

-

}} />

+

}} />

+

); };