mike/vger
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

check request length for empty and too long

Browse source
This commit is contained in:
prx 2021-03-02 10:04:04 +01:00
parent e3b5fb2ab3
commit e87b36c991
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
main.c
View file

@ -20,8 +20,11 @@
#include "utils.h" #include "utils.h"
#define GEMINI_PART 9 #define GEMINI_PART 9
#define GEMINI_REQUEST_MAX 1024 /* see https://gemini.circumlunar.space/docs/specification.html */ /* 2014 + 1
* see https://gemini.circumlunar.space/docs/specification.html.
* fgets() reads at most size-1 (1024 here)
*/
#define GEMINI_REQUEST_MAX 1025
void autoindex(const char *); void autoindex(const char *);
@ -363,6 +366,20 @@ main(int argc, char **argv)
* to get the request * to get the request
*/ */
if (fgets(request, GEMINI_REQUEST_MAX, stdin) == NULL) { if (fgets(request, GEMINI_REQUEST_MAX, stdin) == NULL) {
/* EOF reached before reading anything */
if (feof(stdin)) {
status(59, "request is too short and probably empty");
errlog("request is too short and probably empty");
/* error before reading anything */
} else if (ferror(stdin)) {
status(59, "Error while reading request");
errlog("Error while reading request: %s", request);
}
}
/* check if string ends with '\n', or to long */
if (request[strnlen(request, GEMINI_REQUEST_MAX) - 1] != '\n') {
status(59, "request is too long (1024 max)"); status(59, "request is too long (1024 max)");
errlog("request is too long (1024 max): %s", request); errlog("request is too long (1024 max): %s", request);
} }