Migrate to Glide (#1175)

* Replace Picasso library with Glide library tuskyapp#1082

* Replace Picasso library with Glide library tuskyapp#1082

* Update load emoji with glide

* Update context used for Glide

* Removed unused import

* Replace deprecated SimpleTarget with CustomTarget

* Fix crash at the view image fragment, remove override image size

* Replace Single.create with Single.fromCallable

* View image fragment refactor

* Fix after merge

* Try to load cached image first and show progress view on failure

* Try to load cached image first and show progress view on failure

app/src/main/java/com/keylesspalace/tusky/adapter/AccountSelectionAdapter.kt

@@ -21,10 +21,10 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import android.widget.ArrayAdapter
+import com.bumptech.glide.Glide
 import com.keylesspalace.tusky.R
 import com.keylesspalace.tusky.db.AccountEntity
 import com.keylesspalace.tusky.util.CustomEmojiHelper
-import com.squareup.picasso.Picasso
 
 import kotlinx.android.synthetic.main.item_autocomplete_account.view.*
 
@@ -46,7 +46,7 @@ class AccountSelectionAdapter(context: Context): ArrayAdapter<AccountEntity>(con
             username.text = account.fullName
             displayName.text = CustomEmojiHelper.emojifyString(account.displayName, account.emojis, displayName)
             if (!TextUtils.isEmpty(account.profilePictureUrl)) {
-                Picasso.with(context)
+                Glide.with(avatar)
                         .load(account.profilePictureUrl)
                         .placeholder(R.drawable.avatar_default)
                         .into(avatar)

app/src/main/java/com/keylesspalace/tusky/adapter/AccountViewHolder.java

@@ -8,12 +8,12 @@ import android.view.View;
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.interfaces.LinkListener;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
-import com.squareup.picasso.Picasso;
 
 class AccountViewHolder extends RecyclerView.ViewHolder {
     private TextView username;
@@ -39,8 +39,7 @@ class AccountViewHolder extends RecyclerView.ViewHolder {
         username.setText(formattedUsername);
         CharSequence emojifiedName = CustomEmojiHelper.emojifyString(account.getName(), account.getEmojis(), displayName);
         displayName.setText(emojifiedName);
-        Context context = avatar.getContext();
-        Picasso.with(context)
+        Glide.with(avatar)
                 .load(account.getAvatar())
                 .placeholder(R.drawable.avatar_default)
                 .into(avatar);

app/src/main/java/com/keylesspalace/tusky/adapter/BlocksAdapter.java

@@ -24,11 +24,11 @@ import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
-import com.squareup.picasso.Picasso;
 
 public class BlocksAdapter extends AccountAdapter {
 
@@ -85,7 +85,7 @@ public class BlocksAdapter extends AccountAdapter {
             String format = username.getContext().getString(R.string.status_username_format);
             String formattedUsername = String.format(format, account.getUsername());
             username.setText(formattedUsername);
-            Picasso.with(avatar.getContext())
+            Glide.with(avatar)
                     .load(account.getAvatar())
                     .placeholder(R.drawable.avatar_default)
                     .into(avatar);

app/src/main/java/com/keylesspalace/tusky/adapter/ComposeAutoCompleteAdapter.java

@@ -25,11 +25,11 @@ import android.widget.Filterable;
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.entity.Emoji;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
-import com.squareup.picasso.Picasso;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -147,7 +147,7 @@ public class ComposeAutoCompleteAdapter extends BaseAdapter
                             account.getEmojis(), accountViewHolder.displayName);
                     accountViewHolder.displayName.setText(emojifiedName);
                     if (!account.getAvatar().isEmpty()) {
-                        Picasso.with(context)
+                        Glide.with(accountViewHolder.avatar)
                                 .load(account.getAvatar())
                                 .placeholder(R.drawable.avatar_default)
                                 .into(accountViewHolder.avatar);
@@ -188,7 +188,7 @@ public class ComposeAutoCompleteAdapter extends BaseAdapter
                             emoji.getShortcode()
                     );
                     emojiViewHolder.shortcode.setText(formattedShortcode);
-                    Picasso.with(context)
+                    Glide.with(emojiViewHolder.preview)
                             .load(emoji.getUrl())
                             .into(emojiViewHolder.preview);
                 }

app/src/main/java/com/keylesspalace/tusky/adapter/EmojiAdapter.kt

@@ -19,9 +19,9 @@ import androidx.recyclerview.widget.RecyclerView
 import android.view.LayoutInflater
 import android.view.ViewGroup
 import android.widget.ImageView
+import com.bumptech.glide.Glide
 import com.keylesspalace.tusky.R
 import com.keylesspalace.tusky.entity.Emoji
-import com.squareup.picasso.Picasso
 
 class EmojiAdapter(emojiList: List<Emoji>, private val onEmojiSelectedListener: OnEmojiSelectedListener) : RecyclerView.Adapter<EmojiAdapter.EmojiHolder>() {
     private val emojiList : List<Emoji>
@@ -42,7 +42,7 @@ class EmojiAdapter(emojiList: List<Emoji>, private val onEmojiSelectedListener:
     override fun onBindViewHolder(viewHolder: EmojiAdapter.EmojiHolder, position: Int) {
         val emoji = emojiList[position]
 
-        Picasso.with(viewHolder.emojiImageView.context)
+        Glide.with(viewHolder.emojiImageView)
                 .load(emoji.url)
                 .into(viewHolder.emojiImageView)
 

app/src/main/java/com/keylesspalace/tusky/adapter/FollowRequestsAdapter.java

@@ -24,11 +24,11 @@ import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
-import com.squareup.picasso.Picasso;
 
 public class FollowRequestsAdapter extends AccountAdapter {
 
@@ -87,7 +87,7 @@ public class FollowRequestsAdapter extends AccountAdapter {
             String format = username.getContext().getString(R.string.status_username_format);
             String formattedUsername = String.format(format, account.getUsername());
             username.setText(formattedUsername);
-            Picasso.with(avatar.getContext())
+            Glide.with(avatar)
                     .load(account.getAvatar())
                     .placeholder(R.drawable.avatar_default)
                     .into(avatar);

app/src/main/java/com/keylesspalace/tusky/adapter/MutesAdapter.java

@@ -9,11 +9,11 @@ import android.widget.ImageButton;
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.interfaces.AccountActionListener;
 import com.keylesspalace.tusky.util.CustomEmojiHelper;
-import com.squareup.picasso.Picasso;
 
 public class MutesAdapter extends AccountAdapter {
 
@@ -71,7 +71,7 @@ public class MutesAdapter extends AccountAdapter {
             String format = username.getContext().getString(R.string.status_username_format);
             String formattedUsername = String.format(format, account.getUsername());
             username.setText(formattedUsername);
-            Picasso.with(avatar.getContext())
+            Glide.with(avatar)
                     .load(account.getAvatar())
                     .placeholder(R.drawable.avatar_default)
                     .into(avatar);

app/src/main/java/com/keylesspalace/tusky/adapter/NotificationsAdapter.java

@@ -33,6 +33,7 @@ import android.widget.ImageView;
 import android.widget.TextView;
 import android.widget.ToggleButton;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Account;
 import com.keylesspalace.tusky.entity.Emoji;
@@ -46,7 +47,6 @@ import com.keylesspalace.tusky.util.SmartLengthInputFilter;
 import com.keylesspalace.tusky.viewdata.NotificationViewData;
 import com.keylesspalace.tusky.viewdata.StatusViewData;
 import com.mikepenz.iconics.utils.Utils;
-import com.squareup.picasso.Picasso;
 
 import java.text.SimpleDateFormat;
 import java.util.Date;
@@ -309,9 +309,8 @@ public class NotificationsAdapter extends RecyclerView.Adapter {
             if (TextUtils.isEmpty(account.getAvatar())) {
                 avatar.setImageResource(R.drawable.avatar_default);
             } else {
-                Picasso.with(context)
+                Glide.with(avatar)
                         .load(account.getAvatar())
-                        .fit()
                         .placeholder(R.drawable.avatar_default)
                         .into(avatar);
             }
@@ -487,12 +486,11 @@ public class NotificationsAdapter extends RecyclerView.Adapter {
         }
 
         void setAvatars(@Nullable String statusAvatarUrl, @Nullable String notificationAvatarUrl) {
-            Context context = statusAvatar.getContext();
 
             if (TextUtils.isEmpty(statusAvatarUrl)) {
                 statusAvatar.setImageResource(R.drawable.avatar_default);
             } else {
-                Picasso.with(context)
+                Glide.with(statusAvatar)
                         .load(statusAvatarUrl)
                         .placeholder(R.drawable.avatar_default)
                         .into(statusAvatar);
@@ -501,7 +499,7 @@ public class NotificationsAdapter extends RecyclerView.Adapter {
             if (TextUtils.isEmpty(notificationAvatarUrl)) {
                 notificationAvatar.setImageResource(R.drawable.avatar_default);
             } else {
-                Picasso.with(context)
+                Glide.with(notificationAvatar)
                         .load(notificationAvatarUrl)
                         .placeholder(R.drawable.avatar_default)
                         .into(notificationAvatar);

app/src/main/java/com/keylesspalace/tusky/adapter/StatusBaseViewHolder.java

@@ -12,6 +12,7 @@ import android.widget.ImageView;
 import android.widget.TextView;
 import android.widget.ToggleButton;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Attachment;
 import com.keylesspalace.tusky.entity.Attachment.Focus;
@@ -27,7 +28,6 @@ import com.keylesspalace.tusky.util.ThemeUtils;
 import com.keylesspalace.tusky.view.MediaPreviewImageView;
 import com.keylesspalace.tusky.viewdata.StatusViewData;
 import com.mikepenz.iconics.utils.Utils;
-import com.squareup.picasso.Picasso;
 
 import java.text.NumberFormat;
 import java.text.SimpleDateFormat;
@@ -182,7 +182,7 @@ public abstract class StatusBaseViewHolder extends RecyclerView.ViewHolder {
         if (TextUtils.isEmpty(url)) {
             avatar.setImageResource(R.drawable.avatar_default);
         } else {
-            Picasso.with(avatar.getContext())
+            Glide.with(avatar)
                     .load(url)
                     .placeholder(R.drawable.avatar_default)
                     .into(avatar);
@@ -320,9 +320,6 @@ public abstract class StatusBaseViewHolder extends RecyclerView.ViewHolder {
 
         final int n = Math.min(attachments.size(), Status.MAX_MEDIA_ATTACHMENTS);
 
-        final int maxW = context.getResources().getInteger(R.integer.media_max_width);
-        final int maxH = context.getResources().getInteger(R.integer.media_max_height);
-
         for (int i = 0; i < n; i++) {
             String previewUrl = attachments.get(i).getPreviewUrl();
             String description = attachments.get(i).getDescription();
@@ -336,10 +333,8 @@ public abstract class StatusBaseViewHolder extends RecyclerView.ViewHolder {
             mediaPreviews[i].setVisibility(View.VISIBLE);
 
             if (TextUtils.isEmpty(previewUrl)) {
-                Picasso.with(context)
+                Glide.with(mediaPreviews[i])
                         .load(mediaPreviewUnloadedId)
-                        .resize(maxW, maxH)
-                        .onlyScaleDown()
                         .centerInside()
                         .into(mediaPreviews[i]);
             } else {
@@ -349,23 +344,18 @@ public abstract class StatusBaseViewHolder extends RecyclerView.ViewHolder {
                 if (focus != null) { // If there is a focal point for this attachment:
                     mediaPreviews[i].setFocalPoint(focus);
 
-                    Picasso.with(context)
+                    Glide.with(mediaPreviews[i])
                             .load(previewUrl)
                             .placeholder(mediaPreviewUnloadedId)
-                            .resize(maxW, maxH)
-                            .onlyScaleDown()
                             .centerInside()
-                            // Also pass the mediaPreview as a callback to ensure it is called
-                            // initially when the image gets loaded:
-                            .into(mediaPreviews[i], mediaPreviews[i]);
+                            .addListener(mediaPreviews[i])
+                            .into(mediaPreviews[i]);
                 } else {
                     mediaPreviews[i].removeFocalPoint();
 
-                    Picasso.with(context)
+                    Glide.with(mediaPreviews[i])
                             .load(previewUrl)
                             .placeholder(mediaPreviewUnloadedId)
-                            .resize(maxW, maxH)
-                            .onlyScaleDown()
                             .centerInside()
                             .into(mediaPreviews[i]);
                 }

app/src/main/java/com/keylesspalace/tusky/adapter/StatusDetailedViewHolder.java

@@ -16,6 +16,7 @@ import android.widget.LinearLayout;
 import android.widget.TextView;
 import android.widget.Toast;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.entity.Card;
 import com.keylesspalace.tusky.entity.Status;
@@ -23,7 +24,6 @@ import com.keylesspalace.tusky.interfaces.StatusActionListener;
 import com.keylesspalace.tusky.util.CustomURLSpan;
 import com.keylesspalace.tusky.util.LinkHelper;
 import com.keylesspalace.tusky.viewdata.StatusViewData;
-import com.squareup.picasso.Picasso;
 
 import java.text.DateFormat;
 import java.util.Date;
@@ -176,9 +176,8 @@ class StatusDetailedViewHolder extends StatusBaseViewHolder {
 
                     cardView.setClipToOutline(true);
 
-                    Picasso.with(cardImage.getContext())
+                    Glide.with(cardImage)
                             .load(card.getImage())
-                            .fit()
                             .centerCrop()
                             .into(cardImage);
 

app/src/main/java/com/keylesspalace/tusky/adapter/StatusViewHolder.java

@@ -19,15 +19,14 @@ import android.content.Context;
 import android.text.InputFilter;
 import android.text.TextUtils;
 import android.view.View;
-import android.widget.ImageView;
 import android.widget.TextView;
 import android.widget.ToggleButton;
 
+import com.bumptech.glide.Glide;
 import com.keylesspalace.tusky.R;
 import com.keylesspalace.tusky.interfaces.StatusActionListener;
 import com.keylesspalace.tusky.util.SmartLengthInputFilter;
 import com.keylesspalace.tusky.viewdata.StatusViewData;
-import com.squareup.picasso.Picasso;
 
 import androidx.annotation.Nullable;
 import androidx.recyclerview.widget.RecyclerView;
@@ -55,7 +54,7 @@ public class StatusViewHolder extends StatusBaseViewHolder {
             int padding = Utils.dpToPx(context, 12);
             avatar.setPaddingRelative(0, 0, padding, padding);
             avatarInset.setVisibility(View.VISIBLE);
-            Picasso.with(context)
+            Glide.with(context)
                     .load(rebloggedUrl)
                     .placeholder(R.drawable.avatar_default)
                     .into(avatarInset);