Commit graph

4415 commits

Author SHA1 Message Date
Nik Clayton
8eb195cff6
Enable robolectric logging (#3143)
Robolectric normally swallows output from `Log.*` calls in tests and
the code under test. This can make debugging failing tests more
difficult than it needs to be.

Set `robolectric.logging.enabled` to `true` to enable the logs.
2023-01-12 19:10:11 +01:00
Nik Clayton
561eda8482
Remove rxjava from deletestatus API (#3041)
* Remove rxjava from API calls used by AccountListFragment

* Remove rxjava from API calls used by AccountViewModel::changeRelationship()

The affected API functions are also called from

- ReportViewModel.kt
- SearchViewModel.kt
- AccountListFragment.kt
- SFragment.java
- TimelineCases.kt

so they have also been updated.

This change requires bridging from Java code to Kotlin `suspend` functions,
by creating wrappers for the `mute` and `block` functions that can be
called from Java and create a coroutine scope.

I've deliberately made this fairly ugly so that it sticks out and can be
removed later.

* Use "Throwable" type and name

* Delete 46.json

Not sure where this came from.

* Remove rxjava from the deleteStatus call path

* Emit log messages with the correct tag

* Add another log tag, and lint

* Use TAG in log messages now it's present

* Lint

* Move viewModelScope.launch in to changeRelationshop()

* Use onSuccess/onFailure pair instead of fold

* Return Deferred when deleting statuses
2023-01-10 21:20:00 +01:00
Nik Clayton
c650ca9362
Improve the actual and perceived speed of thread loading (#3118)
* Improve the actual and perceived speed of thread loading

To improve the actual speed, note that if the user has opened a thread from
their home timeline then the initial status is cached in the database. Other
statuses in the same thread may be cached as well.

So try and load the initial status from the database, falling back to the
network if it's not present (e.g., the user has opened a thread from the
local or federated timelines, or a search).

Introduce a new loading state to deal with this case.

In typical cases this allows the UI to display the initial status immediately
with no need to show a progress indicator.

To improve the perceived speed, delay showing the initial loading circular
progress indicators by 500ms. If loading the initial status completes within
that time no spinner is shown and the user will perceive the action as
close-to-immediate
(https://www.nngroup.com/articles/response-times-3-important-limits/).

Additionally, introduce an extra indeterminate progress indicator.

The new indicator is linear, anchored to the bottom of the screen, and shows
progress loading ancestor/descendant statuses. Like the other indicator is
also delayed 500ms from when ancestor/descendant status information is
fetched, and if the fetch completes in that time it will not be shown.

* Mark `getStatus` as suspend so it doesn't run on the main thread

* Save an allocation, use an isDetailed parameter to TimelineStatusWithAccount.toViewData

Rename Status.toViewData's "detailed" parameter to "isDetailed" for
consistency with other uses.

* Ensure suspend functions run to completion when testing

* Delay-load the status from the network even if it's cached

This speeds up the UI while ensuring it will eventually contain accurate data
from the remote.

* Load the network status before updating the list

Avoids excess animations if the network copy has changes

* Fix UI flicker when loading reblogged statuses

* Lint

* Fixup tests
2023-01-09 21:31:31 +01:00
Nik Clayton
d645416028
Show a close button for hashtag tab chips (#3140)
The intent of the previous code seems to be to show an "X" icon on a hashtag
chip when two or more chips are present.

This didn't work because the icon was not set as visible.

Fix this. In addition, set this as a "cancel" icon, not the chip's regular
icon, so it appears on the right (in LTR locales), as is normal for the
close button on chips.

Tinting the icon did nothing, so remove that.
2023-01-09 21:24:37 +01:00
Konrad Pozniak
95631069b8
don't crash on unparseable date (#3129) 2023-01-09 21:24:04 +01:00
mcclure
59fb710f64
Share and copy menu items for account page (#3120)
* Share and copy menu items for account page (first attempt)]

* Always include domain in username in 'handle' copy

* Remove profile copy options, rename 'handle' to 'username'

* Long press on username in profile to copy it to clipboard

* Changes for code review: localUsername not username, Snackbar not Toast

* Do not trust getDomain() when getting full username. This means full-username build has to happen in AccountActivity instead of Account

* Replace != null -> \!\! idiom with more kotlin-y (and more threadsafe) ?.let pattern

* Unnecessary import

* Comment clarifying safety of \!\!
2023-01-09 21:08:46 +01:00
Levi Bard
8ca92d9fde
Add new mastodon status url format to looksLikeMastodonUrl. (#3136)
Fixes #3092
2023-01-09 21:07:22 +01:00
Constantin A
ca01776847
Update FilemojiCompat to version 3.2.7 (#3151) 2023-01-09 21:06:47 +01:00
Nik Clayton
0328c4e876
Convert "title case" strings to "sentence case" (#3132)
Tusky mostly uses (correctly, per Android style guide) sentence case (i.e.,
a single initial capital letter) in strings like "Scheduled posts" or
"Muted users".

But there are a few instances of title case (i.e., each initial letter is
capitalised) that have crept in ("Account Preferences", "Log Out",
"Follow Requests", etc).

Convert them to sentence case.
2023-01-03 21:07:04 +01:00
Konrad Pozniak
eb02d0b6ce
Merge pull request #3128 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-01-02 17:34:58 +01:00
Manuel
ee2309cee8 Translated using Weblate (Italian)
Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Manuel <mannivuwiki@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Weblate
8602337aae Update translation files
Updated by "Cleanup translation files" hook in Weblate.

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Hồ Nhất Duy
35ef723286 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Hồ Nhất Duy <mastoduy@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Ihor Hordiichuk
753d551d95 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/uk/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Eric
5cdfca7b04 Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Eric <alchemillatruth@purelymail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/zh_Hans/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Manuel
ff9ad0d1fc Translated using Weblate (Italian)
Currently translated at 99.4% (535 of 538 strings)

Co-authored-by: Manuel <manueltassi91@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Andrés Blasco Arnáiz
e104b5731f Translated using Weblate (Spanish)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Andrés Blasco Arnáiz <andresbarnaiz@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/es/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Newidyn
827ee2188a Translated using Weblate (Welsh)
Currently translated at 98.7% (533 of 540 strings)

Translated using Weblate (Welsh)

Currently translated at 99.4% (535 of 538 strings)

Co-authored-by: Newidyn <grugallt@protonmail.ch>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Conny Duck
468f8f1b14 use MaterialColors.getColor instead of ThemeUtils (fixes build) 2023-01-02 14:36:07 +01:00
Konrad Pozniak
33e4da7abb
Improve muted users list (#3127)
* migrate MutesAdapter to viewbinding

* migrate item_muted_user to ConstraintLayout

* add switch instead of button

* change unmute button position

* delete unused string
2023-01-02 14:09:40 +01:00
Konrad Pozniak
61a45ae376
show status edits (#3049)
* show status edits part 1

* show status edits part 2 - load status edits

* fix code formatting

* add dialog to show status edits

* small improvements

* use ALIGN_CENTER to position status visibility icon when possible

* rename status_timestamp_info view to status_meta_info

* make dateFormat static

* remove commented-out code

* move edits to dedicated fragment
2023-01-02 14:09:18 +01:00
Konrad Pozniak
8c0f02cf33
Merge pull request #3109 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2022-12-31 13:08:05 +01:00
Nik Clayton
a5f479d79c
Fix saving changes to statuses when editing (#3103)
* Fix saving changes to statuses when editing

With the previous code backing out of a status editing operation where changes
had been made  (whether it was editing an existing status, a scheduled status,
or a draft) would prompt the user to save the changes as a new draft.

See https://github.com/tuskyapp/Tusky/issues/2704 and
https://github.com/tuskyapp/Tusky/issues/2705 for more detail.

The fix:

- Create an enum to represent the four different kinds of edits that can
  happen
  - Editing a new status (i.e., composing it for the first time)
  - Editing a posted status
  - Editing a draft
  - Editing a scheduled status

- Store this in ComposeOptions, and set it appropriately everywhere
  ComposeOptions is created.

- Check the edit kind when backing out of ComposeActivity, and use this to
  show one of three different dialogs as appropriate so the user can:
  - Save as new draft or discard changes
  - Continue editing or discard changes
  - Update existing draft or discard changes

Also fix ComposeViewModel.didChange(), which erroneously reported false if the
old text started with the new text (e.g., if the old text was "hello, world"
and it was edited to "hello", didChange() would not consider that to be a
change).

Fixes https://github.com/tuskyapp/Tusky/issues/2704,
https://github.com/tuskyapp/Tusky/issues/2705

* Use orEmpty extension function
2022-12-31 13:04:49 +01:00
Nik Clayton
2e72fa0dfc
Handle preference fragments using the framework (#3090)
* Handle preference fragments using the framework

The previous code started new preference "screens" as activities, even though
each one hosted a single fragment.

Modify this to use the framework's support for swapping in/out different
preference fragments.

PreferencesActivity:
- Remove the code for launching tab and proxy preferences
- Remove the code for setting titles, each fragment is responsible for that
- Implement OnPreferenceStartFragmentCallback to swap fragments in/out with
  the correct animation

PreferencesFragment:
- Use `fragment` property instead of `setOnPreferenceClickListener`
- Set the activity title when resuming

Everything else:
- Set the activity title when resuming

* Lint

* Use the commit extension function
2022-12-31 13:02:23 +01:00
Mārtiņš Bruņenieks
b516da29b0 Translated using Weblate (Latvian)
Currently translated at 49.9% (267 of 535 strings)

Translated using Weblate (Latvian)

Currently translated at 49.7% (266 of 535 strings)

Co-authored-by: Mārtiņš Bruņenieks <martinsb@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/lv/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
xzFantom
a6e711d04e Translated using Weblate (Belarusian)
Currently translated at 63.3% (339 of 535 strings)

Translated using Weblate (Belarusian)

Currently translated at 59.4% (318 of 535 strings)

Co-authored-by: xzFantom <xzfantom@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/be/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
XoseM
52cb7e6538 Translated using Weblate (Galician)
Currently translated at 100.0% (535 of 535 strings)

Co-authored-by: XoseM <xosem@disroot.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/gl/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Hồ Nhất Duy
e8e82fe3d2 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (535 of 535 strings)

Co-authored-by: Hồ Nhất Duy <duy@tutamail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Umit Kabuli
7d485923ba Translated using Weblate (Turkish)
Currently translated at 100.0% (535 of 535 strings)

Co-authored-by: Umit Kabuli <umitkabuli@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/tr/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Yavuz Selim
ede626bbd7 Translated using Weblate (Dutch)
Currently translated at 93.2% (499 of 535 strings)

Co-authored-by: Yavuz Selim <yzsmo+tusky.app@pm.me>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/nl/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Danial Behzadi
4932c08eb5 Translated using Weblate (Persian)
Currently translated at 100.0% (535 of 535 strings)

Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/fa/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Andrés Blasco Arnáiz
4d6244d9d0 Translated using Weblate (Spanish)
Currently translated at 100.0% (535 of 535 strings)

Co-authored-by: Andrés Blasco Arnáiz <andresbarnaiz@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/es/
Translation: Tusky/Tusky
2022-12-31 12:01:53 +00:00
Nik Clayton
22834431ca
Convert util/{HttpHeaderLink,PairedList,TimestampUtils,ThemeUtils} to Kotlin (#3046)
* Fix off-by-one error in HttpHeaderLink

Link headers with multiple URLs with multiple parameters were being parsed
incorrectly.

Detected by adding unit tests ahead of converting to Kotlin.

* Convert util/HttpHeaderLink from Java to Kotlin

* Convert util/ThemeUtils from Java to Kotlin

* Convert util/TimestampUtils from Java to Kotlin

* Add tests for PairedList

* Convert util/PairedList from Java to Kotlin

* Implement feedback from PR

* Relicense as GPL
2022-12-31 13:01:35 +01:00
Nik Clayton
0def7e7230
Provide default text sizes in TuskyBaseTheme (#3108)
These aren't necessary for the app, and are overwritten with the actual style
in `BaseActivity.onCreate()`.

But if they're missing the Android Studio layout preview renderer crashes.
2022-12-30 13:11:26 +01:00
Nik Clayton
62a8a4a60a
Leave the "edit scheduled status" button enabled after clicking (#3100)
* Leave the "edit scheduled status" button enabled after clicking

If the user submits an edit to the scheduled status then this one will be deleted, the paging source will notice, the adapter will be notified in the normal way, and this binding will be reused.

Or the user backs out of the edit, and this adapter entry is still valid and should remain clickable.

Fixes https://github.com/tuskyapp/Tusky/issues/2705

* Remove unnecessary parameter.

* Remove unnecessary import
2022-12-30 12:09:42 +01:00
Nik Clayton
02cadd5d33
Ensure text content is always pasted as plain text (#3083)
Fixes https://github.com/tuskyapp/Tusky/issues/3082.
2022-12-30 11:41:48 +01:00
Nik Clayton
c07dd0f919
Remove debug logging of keypresses (#3075)
While only present in a Log.d call, which should be stripped out of release
builds, this feels like an unnecessary privacy risk.
2022-12-30 11:41:11 +01:00
Eric Frohnhoefer
3170e1ce71
Fix auto play when swiping between attachments (#3077)
* Fix auto play when swiping between attachments

Fixes an issue where attachment doesn't autoplay when swiping left/right from initial attachment.

Fixes #3066

* Fix lint error for wild card imports
2022-12-30 11:22:39 +01:00
Eric Frohnhoefer
65e95a7858
Add FAB to self account view (#3067)
Fixes 3058
2022-12-30 11:22:01 +01:00
Eva Tatarka
c7254bfc19
Left-align image alt text & make it selectable (#3063)
Fixes #2819, #2126
2022-12-30 11:20:25 +01:00
Konrad Pozniak
abca91a420
Handoff media upload (#2947)
* handoff media upload to SendStatusService

* fix bugd

* improve code

* don't check processing state when upload returned 200
2022-12-29 19:58:23 +01:00
Konrad Pozniak
9cf949fc2e
add 46.json (#3116) 2022-12-29 19:29:33 +01:00
Konrad Pozniak
3a128ff75f
Merge pull request #3026 from nailyk-weblate/weblate-tusky-tusky-app
Translations update from Weblate
2022-12-28 19:08:57 +01:00
Nik Clayton
ee765a3117
Convert AccountViewHolder from Java to Kotlin (#3044)
* Convert AccountViewHolder from Java to Kotlin

Use view binding in the converted code, which requires small changes in code
that calls constructors.

Pass showBotOverlays as a parameter, rather than having the code reach in to
the shared preferences, fixing a layering violation. This affects callers
and classes derived from AccountAdapter.

* Use 2-arg getString

* Simplify setting bot badge indicator

- Specify the drawable in the XML
- Use visible() to set visibility
- Rename ID to account_bot_badge to make it clearer that this is all it is for

* Use lateinit to avoid needing !! later
2022-12-28 19:07:43 +01:00
Nik Clayton
a21f2fadf9
Remove rxjava from API calls used by AccountViewModel::changeRelationship() (#3008)
* Remove rxjava from API calls used by AccountListFragment

* Remove rxjava from API calls used by AccountViewModel::changeRelationship()

The affected API functions are also called from

- ReportViewModel.kt
- SearchViewModel.kt
- AccountListFragment.kt
- SFragment.java
- TimelineCases.kt

so they have also been updated.

This change requires bridging from Java code to Kotlin `suspend` functions,
by creating wrappers for the `mute` and `block` functions that can be
called from Java and create a coroutine scope.

I've deliberately made this fairly ugly so that it sticks out and can be
removed later.

* Use "Throwable" type and name

* Delete 46.json

Not sure where this came from.

* Emit log messages with the correct tag

* Add another log tag, and lint

* Move viewModelScope.launch in to changeRelationshop()
2022-12-28 19:06:31 +01:00
Danial Behzadi
c9ac52c76e Translated using Weblate (Persian)
Currently translated at 89.4% (17 of 19 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/fa/
2022-12-28 18:05:00 +00:00
Mārtiņš Bruņenieks
8a28414dfd Translated using Weblate (Latvian)
Currently translated at 10.5% (2 of 19 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/lv/
2022-12-28 18:05:00 +00:00
xzFantom
ac19b4a23c Translated using Weblate (Belarusian)
Currently translated at 5.2% (1 of 19 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/be/
2022-12-28 18:05:00 +00:00
Jan Lindblom
9acd888d17 Translated using Weblate (Swedish)
Currently translated at 63.1% (12 of 19 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/sv/
2022-12-28 18:05:00 +00:00
Umit Kabuli
2360b13826 Translated using Weblate (Turkish)
Currently translated at 100.0% (19 of 19 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/tr/
2022-12-28 18:04:59 +00:00