chinwag-android/app/src/main/java/com/keylesspalace/tusky
Nik Clayton c36b243745
Show reblog/favourite confirmations as menus not dialogs (#3418)
* Show reblog/favourite confirmations as menus not dialogs

The previous code used dialogs and displayed the text of the status when
reblogging or favouriting.

This didn't work when the post just contained images, and other material
from the status (content warning, polls) was not shown either.

Fix this by displaying a popup menu instead. The status remains visible so
the user can clearly see what they're acting on.

In addition, this lays the groundwork for supporting a long-press menu
in the future to allow the user to reblog/favourite from a different
account.

Fixes https://github.com/tuskyapp/Tusky/issues/3308

* Revert the change that puts the menu immediately over the icon

Although this behavious is consistent with how the option menu works, I
decided that the risk of someone inadvertently double-tapping in the same
location, and the first tap opens the menu and the second tap confirms the
action was too great.

So now the menu appears either above or below the icon depending on space,
and the user has to tap in two slightly different spaces.

This is also consistent with the previous behaviour, where it's highly
unlikely that the confirm button on the dialog would have been directly
under the user's finger if they double-tapped.
2023-03-18 09:37:55 +01:00
..
adapter Show reblog/favourite confirmations as menus not dialogs (#3418) 2023-03-18 09:37:55 +01:00
appstore Remove stale pre-edit statuses from the thread view. (#3377) 2023-03-10 20:24:41 +01:00
components Show toot stat inline (#3413) 2023-03-18 08:57:26 +01:00
db Fix doubled line from PR 3188 (support mastodon filter api) (#3460) 2023-03-18 08:05:39 +01:00
di update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
entity update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
fragment update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
interfaces Support the mastodon 4 filter api (#3188) 2023-03-11 13:12:50 +01:00
json update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
network update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
pager Keep the tabs adapter over the life of the viewpager (#3255) 2023-02-15 19:17:59 +01:00
receiver update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
service update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
settings Show toot stat inline (#3413) 2023-03-18 08:57:26 +01:00
usecase Convert NotificationsFragment and related code to Kotlin, use the Paging library (#3159) 2023-03-10 20:12:33 +01:00
util Show toot stat inline (#3413) 2023-03-18 08:57:26 +01:00
view Meet accessibility guidelines for clickable spans (#3382) 2023-03-18 08:57:39 +01:00
viewdata update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
viewmodel update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
AboutActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
AccountsInListFragment.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
BaseActivity.java Code cleanups (#3264) 2023-02-20 19:58:37 +01:00
BottomSheetActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
EditProfileActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
LicenseActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
ListsActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
MainActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
SplashActivity.kt remove legacy notification channel cleanup (#2550) 2022-05-25 20:54:25 +02:00
StatusListActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
TabData.kt Convert NotificationsFragment and related code to Kotlin, use the Paging library (#3159) 2023-03-10 20:12:33 +01:00
TabPreferenceActivity.kt remove Rx from TabPreferenceActivity (#3444) 2023-03-13 13:16:58 +01:00
TuskyApplication.kt 3204: Add an account based preference store (#3205) 2023-02-27 14:07:28 +01:00
ViewMediaActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00