2023-02-22 11:55:31 +11:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2022-02-10 10:15:30 +11:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2024-03-13 19:39:26 +11:00
|
|
|
RSpec.describe UpdateStatusService do
|
2022-02-10 10:15:30 +11:00
|
|
|
subject { described_class.new }
|
|
|
|
|
2022-03-26 10:38:44 +11:00
|
|
|
context 'when nothing changes' do
|
|
|
|
let!(:status) { Fabricate(:status, text: 'Foo', language: 'en') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(ActivityPub::DistributionWorker).to receive(:perform_async)
|
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'does not create an edit or notify anyone' do
|
|
|
|
subject.call(status, status.account_id, text: 'Foo')
|
2022-03-26 10:38:44 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.reload.edits)
|
|
|
|
.to be_empty
|
|
|
|
expect(ActivityPub::DistributionWorker)
|
|
|
|
.to_not have_received(:perform_async)
|
2022-03-26 10:38:44 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-02-10 10:15:30 +11:00
|
|
|
context 'when text changes' do
|
2023-11-13 20:58:28 +11:00
|
|
|
let(:status) { Fabricate(:status, text: 'Foo') }
|
2022-02-10 10:15:30 +11:00
|
|
|
let(:preview_card) { Fabricate(:preview_card) }
|
|
|
|
|
|
|
|
before do
|
2023-11-13 20:58:28 +11:00
|
|
|
PreviewCardsStatus.create(status: status, preview_card: preview_card)
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'updates text, resets card, saves edit history' do
|
|
|
|
subject.call(status, status.account_id, text: 'Bar')
|
2022-02-10 10:15:30 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.reload)
|
|
|
|
.to have_attributes(
|
|
|
|
text: 'Bar',
|
|
|
|
preview_card: be_nil
|
|
|
|
)
|
2024-04-22 18:30:38 +10:00
|
|
|
expect(status.edits.ordered.pluck(:text)).to eq %w(Foo Bar)
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when content warning changes' do
|
2023-11-13 20:58:28 +11:00
|
|
|
let(:status) { Fabricate(:status, text: 'Foo', spoiler_text: '') }
|
2022-02-10 10:15:30 +11:00
|
|
|
let(:preview_card) { Fabricate(:preview_card) }
|
|
|
|
|
|
|
|
before do
|
2023-11-13 20:58:28 +11:00
|
|
|
PreviewCardsStatus.create(status: status, preview_card: preview_card)
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'updates content warning and saves history' do
|
|
|
|
subject.call(status, status.account_id, text: 'Foo', spoiler_text: 'Bar')
|
2022-02-10 10:15:30 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.reload.spoiler_text)
|
|
|
|
.to eq 'Bar'
|
|
|
|
expect(status.edits.ordered.pluck(:text, :spoiler_text))
|
|
|
|
.to eq [['Foo', ''], ['Foo', 'Bar']]
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when media attachments change' do
|
|
|
|
let!(:status) { Fabricate(:status, text: 'Foo') }
|
|
|
|
let!(:detached_media_attachment) { Fabricate(:media_attachment, account: status.account) }
|
|
|
|
let!(:attached_media_attachment) { Fabricate(:media_attachment, account: status.account) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
status.media_attachments << detached_media_attachment
|
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'updates media attachments, handles attachments, saves history' do
|
|
|
|
subject.call(status, status.account_id, text: 'Foo', media_ids: [attached_media_attachment.id.to_s])
|
2022-02-10 10:15:30 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.ordered_media_attachments)
|
|
|
|
.to eq [attached_media_attachment]
|
|
|
|
expect(detached_media_attachment.reload.status_id)
|
|
|
|
.to eq status.id
|
|
|
|
expect(attached_media_attachment.reload.status_id)
|
|
|
|
.to eq status.id
|
|
|
|
expect(status.edits.ordered.pluck(:ordered_media_attachment_ids))
|
|
|
|
.to eq [[detached_media_attachment.id], [attached_media_attachment.id]]
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-01-19 02:33:55 +11:00
|
|
|
context 'when already-attached media changes' do
|
|
|
|
let!(:status) { Fabricate(:status, text: 'Foo') }
|
|
|
|
let!(:media_attachment) { Fabricate(:media_attachment, account: status.account, description: 'Old description') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
status.media_attachments << media_attachment
|
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'does not detach media attachment, updates description, and saves history' do
|
|
|
|
subject.call(status, status.account_id, text: 'Foo', media_ids: [media_attachment.id.to_s], media_attributes: [{ id: media_attachment.id, description: 'New description' }])
|
2023-01-19 02:33:55 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(media_attachment.reload)
|
|
|
|
.to have_attributes(
|
|
|
|
status_id: status.id,
|
|
|
|
description: 'New description'
|
|
|
|
)
|
|
|
|
expect(status.edits.ordered.map { |edit| edit.ordered_media_attachments.map(&:description) })
|
|
|
|
.to eq [['Old description'], ['New description']]
|
2023-01-19 02:33:55 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2024-01-10 22:06:58 +11:00
|
|
|
context 'when poll changes' do
|
2022-02-11 00:26:54 +11:00
|
|
|
let(:account) { Fabricate(:account) }
|
2023-02-18 08:56:20 +11:00
|
|
|
let!(:status) { Fabricate(:status, text: 'Foo', account: account, poll_attributes: { options: %w(Foo Bar), account: account, multiple: false, hide_totals: false, expires_at: 7.days.from_now }) }
|
2022-02-11 00:26:54 +11:00
|
|
|
let!(:poll) { status.poll }
|
|
|
|
let!(:voter) { Fabricate(:account) }
|
2022-02-10 10:15:30 +11:00
|
|
|
|
|
|
|
before do
|
|
|
|
status.update(poll: poll)
|
2022-02-11 00:26:54 +11:00
|
|
|
VoteService.new.call(voter, poll, [0])
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'updates poll, resets votes, saves history, requeues notifications' do
|
|
|
|
subject.call(status, status.account_id, text: 'Foo', poll: { options: %w(Bar Baz Foo), expires_in: 5.days.to_i })
|
2022-02-11 00:26:54 +11:00
|
|
|
|
|
|
|
poll = status.poll.reload
|
2022-02-10 10:15:30 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(poll)
|
|
|
|
.to have_attributes(
|
|
|
|
options: %w(Bar Baz Foo),
|
|
|
|
votes_count: 0,
|
|
|
|
cached_tallies: [0, 0, 0]
|
|
|
|
)
|
|
|
|
expect(poll.votes.count)
|
|
|
|
.to eq(0)
|
2023-03-29 19:52:40 +11:00
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.edits.ordered.pluck(:poll_options))
|
|
|
|
.to eq [%w(Foo Bar), %w(Bar Baz Foo)]
|
|
|
|
|
|
|
|
expect(PollExpirationNotifyWorker)
|
|
|
|
.to have_enqueued_sidekiq_job(poll.id).at(poll.expires_at + 5.minutes)
|
2023-03-29 19:52:40 +11:00
|
|
|
end
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when mentions in text change' do
|
|
|
|
let!(:account) { Fabricate(:account) }
|
|
|
|
let!(:alice) { Fabricate(:account, username: 'alice') }
|
|
|
|
let!(:bob) { Fabricate(:account, username: 'bob') }
|
|
|
|
let!(:status) { PostStatusService.new.call(account, text: 'Hello @alice') }
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'changes mentions and keeps old as silent' do
|
2022-02-10 10:15:30 +11:00
|
|
|
subject.call(status, status.account_id, text: 'Hello @bob')
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
expect(status.active_mentions.pluck(:account_id))
|
|
|
|
.to eq [bob.id]
|
|
|
|
expect(status.mentions.pluck(:account_id))
|
|
|
|
.to contain_exactly(alice.id, bob.id)
|
2022-02-10 10:15:30 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when hashtags in text change' do
|
|
|
|
let!(:account) { Fabricate(:account) }
|
|
|
|
let!(:status) { PostStatusService.new.call(account, text: 'Hello #foo') }
|
|
|
|
|
2024-10-05 00:11:15 +10:00
|
|
|
it 'changes tags' do
|
2022-02-10 10:15:30 +11:00
|
|
|
subject.call(status, status.account_id, text: 'Hello #bar')
|
|
|
|
|
|
|
|
expect(status.tags.pluck(:name)).to eq %w(bar)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'notifies ActivityPub about the update' do
|
|
|
|
status = Fabricate(:status, text: 'Foo')
|
|
|
|
allow(ActivityPub::DistributionWorker).to receive(:perform_async)
|
|
|
|
subject.call(status, status.account_id, text: 'Bar')
|
|
|
|
expect(ActivityPub::DistributionWorker).to have_received(:perform_async)
|
|
|
|
end
|
|
|
|
end
|