2019-11-07 18:05:07 +11:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'rails_helper'
|
|
|
|
|
2024-09-04 15:12:25 +10:00
|
|
|
RSpec.describe MoveWorker do
|
2023-02-20 15:24:14 +11:00
|
|
|
subject { described_class.new }
|
|
|
|
|
2023-05-03 22:03:38 +10:00
|
|
|
let(:local_follower) { Fabricate(:account, domain: nil) }
|
2022-01-28 10:46:42 +11:00
|
|
|
let(:blocking_account) { Fabricate(:account) }
|
|
|
|
let(:muting_account) { Fabricate(:account) }
|
2023-05-03 22:03:38 +10:00
|
|
|
let(:source_account) { Fabricate(:account, protocol: :activitypub, domain: 'example.com', uri: 'https://example.org/a', inbox_url: 'https://example.org/a/inbox') }
|
|
|
|
let(:target_account) { Fabricate(:account, protocol: :activitypub, domain: 'example.com', uri: 'https://example.org/b', inbox_url: 'https://example.org/b/inbox') }
|
2020-07-01 03:19:50 +10:00
|
|
|
let(:local_user) { Fabricate(:user) }
|
2021-11-06 10:12:25 +11:00
|
|
|
let(:comment) { 'old note prior to move' }
|
|
|
|
let!(:account_note) { Fabricate(:account_note, account: local_user.account, target_account: source_account, comment: comment) }
|
2023-05-03 22:03:38 +10:00
|
|
|
let(:list) { Fabricate(:list, account: local_follower) }
|
2019-11-07 18:05:07 +11:00
|
|
|
|
2023-06-22 22:55:22 +10:00
|
|
|
let(:block_service) { instance_double(BlockService) }
|
2020-07-01 21:51:15 +10:00
|
|
|
|
2019-11-07 18:05:07 +11:00
|
|
|
before do
|
2023-05-03 22:03:38 +10:00
|
|
|
stub_request(:post, 'https://example.org/a/inbox').to_return(status: 200)
|
|
|
|
stub_request(:post, 'https://example.org/b/inbox').to_return(status: 200)
|
|
|
|
|
2019-11-07 18:05:07 +11:00
|
|
|
local_follower.follow!(source_account)
|
2020-07-01 21:51:15 +10:00
|
|
|
blocking_account.block!(source_account)
|
|
|
|
muting_account.mute!(source_account)
|
|
|
|
|
2023-05-03 22:03:38 +10:00
|
|
|
list.accounts << source_account
|
|
|
|
|
2020-07-01 21:51:15 +10:00
|
|
|
allow(BlockService).to receive(:new).and_return(block_service)
|
|
|
|
allow(block_service).to receive(:call)
|
2019-11-07 18:05:07 +11:00
|
|
|
end
|
|
|
|
|
2020-07-01 03:19:50 +10:00
|
|
|
shared_examples 'user note handling' do
|
2021-11-06 10:12:25 +11:00
|
|
|
context 'when user notes are short enough' do
|
|
|
|
it 'copies user note with prelude' do
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-11-16 21:03:51 +11:00
|
|
|
expect(relevant_account_note.comment)
|
|
|
|
.to include(source_account.acct, account_note.comment)
|
2021-11-06 10:12:25 +11:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'merges user notes when needed' do
|
|
|
|
new_account_note = AccountNote.create!(account: account_note.account, target_account: target_account, comment: 'new note prior to move')
|
|
|
|
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-11-16 21:03:51 +11:00
|
|
|
expect(relevant_account_note.comment)
|
|
|
|
.to include(source_account.acct, account_note.comment, new_account_note.comment)
|
2021-11-06 10:12:25 +11:00
|
|
|
end
|
2020-07-01 03:19:50 +10:00
|
|
|
end
|
|
|
|
|
2021-11-06 10:12:25 +11:00
|
|
|
context 'when user notes are too long' do
|
|
|
|
let(:comment) { 'abc' * 333 }
|
2020-07-01 03:19:50 +10:00
|
|
|
|
2021-11-06 10:12:25 +11:00
|
|
|
it 'copies user note without prelude' do
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-11-16 21:03:51 +11:00
|
|
|
expect(relevant_account_note.comment)
|
|
|
|
.to include(account_note.comment)
|
2021-11-06 10:12:25 +11:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'keeps user notes unchanged' do
|
|
|
|
new_account_note = AccountNote.create!(account: account_note.account, target_account: target_account, comment: 'new note prior to move')
|
|
|
|
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-11-16 21:03:51 +11:00
|
|
|
expect(relevant_account_note.comment)
|
|
|
|
.to include(new_account_note.comment)
|
2021-11-06 10:12:25 +11:00
|
|
|
end
|
2020-07-01 03:19:50 +10:00
|
|
|
end
|
2023-11-16 21:03:51 +11:00
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def relevant_account_note
|
|
|
|
AccountNote.find_by(account: account_note.account, target_account: target_account)
|
|
|
|
end
|
2020-07-01 03:19:50 +10:00
|
|
|
end
|
|
|
|
|
2020-07-01 21:51:15 +10:00
|
|
|
shared_examples 'block and mute handling' do
|
2023-10-14 00:50:46 +11:00
|
|
|
it 'makes blocks and mutes carry over and adds a note' do
|
2020-07-01 21:51:15 +10:00
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-10-14 00:50:46 +11:00
|
|
|
|
2020-07-01 21:51:15 +10:00
|
|
|
expect(block_service).to have_received(:call).with(blocking_account, target_account)
|
|
|
|
expect(muting_account.muting?(target_account)).to be true
|
2023-11-16 21:03:51 +11:00
|
|
|
|
|
|
|
expect(
|
|
|
|
[note_account_comment, mute_account_comment]
|
|
|
|
).to all include(source_account.acct)
|
|
|
|
end
|
|
|
|
|
|
|
|
def note_account_comment
|
|
|
|
AccountNote.find_by(account: blocking_account, target_account: target_account).comment
|
|
|
|
end
|
|
|
|
|
|
|
|
def mute_account_comment
|
|
|
|
AccountNote.find_by(account: muting_account, target_account: target_account).comment
|
2020-07-01 21:51:15 +10:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-11-08 01:38:55 +11:00
|
|
|
shared_examples 'followers count handling' do
|
2023-10-14 00:50:46 +11:00
|
|
|
it 'updates the source and target account followers counts' do
|
2022-11-08 01:38:55 +11:00
|
|
|
subject.perform(source_account.id, target_account.id)
|
|
|
|
|
2023-10-14 00:50:46 +11:00
|
|
|
expect(source_account.reload.followers_count).to eq(source_account.passive_relationships.count)
|
2022-11-08 01:38:55 +11:00
|
|
|
expect(target_account.reload.followers_count).to eq(target_account.passive_relationships.count)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-03 22:03:38 +10:00
|
|
|
shared_examples 'lists handling' do
|
2024-07-09 02:01:08 +10:00
|
|
|
it 'puts the new account on the list and makes valid lists', :inline_jobs do
|
2023-05-03 22:03:38 +10:00
|
|
|
subject.perform(source_account.id, target_account.id)
|
2023-05-04 03:19:25 +10:00
|
|
|
|
2023-10-14 00:50:46 +11:00
|
|
|
expect(list.accounts.include?(target_account)).to be true
|
2023-05-04 03:19:25 +10:00
|
|
|
expect(ListAccount.all).to all be_valid
|
|
|
|
end
|
2023-05-03 22:03:38 +10:00
|
|
|
end
|
|
|
|
|
2023-05-04 03:19:25 +10:00
|
|
|
shared_examples 'common tests' do
|
|
|
|
include_examples 'user note handling'
|
|
|
|
include_examples 'block and mute handling'
|
|
|
|
include_examples 'followers count handling'
|
|
|
|
include_examples 'lists handling'
|
|
|
|
|
|
|
|
context 'when a local user already follows both source and target' do
|
|
|
|
before do
|
|
|
|
local_follower.request_follow!(target_account)
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'user note handling'
|
|
|
|
include_examples 'block and mute handling'
|
|
|
|
include_examples 'followers count handling'
|
|
|
|
include_examples 'lists handling'
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when the local user already has the target in a list' do
|
2023-05-04 03:19:25 +10:00
|
|
|
before do
|
|
|
|
list.accounts << target_account
|
2023-05-03 22:03:38 +10:00
|
|
|
end
|
2023-05-04 03:19:25 +10:00
|
|
|
|
|
|
|
include_examples 'lists handling'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a local follower already has a pending request to the target' do
|
|
|
|
before do
|
|
|
|
local_follower.follow!(target_account)
|
2019-11-07 18:05:07 +11:00
|
|
|
end
|
2020-07-01 03:19:50 +10:00
|
|
|
|
|
|
|
include_examples 'user note handling'
|
2020-07-01 21:51:15 +10:00
|
|
|
include_examples 'block and mute handling'
|
2022-11-08 01:38:55 +11:00
|
|
|
include_examples 'followers count handling'
|
2023-05-03 22:03:38 +10:00
|
|
|
include_examples 'lists handling'
|
2023-05-04 03:19:25 +10:00
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when the local user already has the target in a list' do
|
2023-05-04 03:19:25 +10:00
|
|
|
before do
|
|
|
|
list.accounts << target_account
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'lists handling'
|
|
|
|
end
|
2019-11-07 18:05:07 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 03:19:25 +10:00
|
|
|
describe '#perform' do
|
|
|
|
context 'when both accounts are distant' do
|
2024-01-10 22:06:58 +11:00
|
|
|
it 'calls UnfollowFollowWorker' do
|
2023-11-23 20:43:43 +11:00
|
|
|
subject.perform(source_account.id, target_account.id)
|
|
|
|
expect(UnfollowFollowWorker).to have_enqueued_sidekiq_job(local_follower.id, source_account.id, target_account.id, false)
|
2023-05-04 03:19:25 +10:00
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'common tests'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when target account is local' do
|
|
|
|
let(:target_account) { Fabricate(:account) }
|
2019-11-07 18:05:07 +11:00
|
|
|
|
2024-01-10 22:06:58 +11:00
|
|
|
it 'calls UnfollowFollowWorker' do
|
2023-11-23 20:43:43 +11:00
|
|
|
subject.perform(source_account.id, target_account.id)
|
|
|
|
expect(UnfollowFollowWorker).to have_enqueued_sidekiq_job(local_follower.id, source_account.id, target_account.id, true)
|
2019-11-07 18:05:07 +11:00
|
|
|
end
|
2020-07-01 03:19:50 +10:00
|
|
|
|
2023-05-04 03:19:25 +10:00
|
|
|
include_examples 'common tests'
|
2019-11-07 18:05:07 +11:00
|
|
|
end
|
|
|
|
|
2023-05-04 03:19:25 +10:00
|
|
|
context 'when both target and source accounts are local' do
|
|
|
|
let(:target_account) { Fabricate(:account) }
|
|
|
|
let(:source_account) { Fabricate(:account) }
|
2019-11-07 18:05:07 +11:00
|
|
|
|
|
|
|
it 'calls makes local followers follow the target account' do
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
|
|
|
expect(local_follower.following?(target_account)).to be true
|
|
|
|
end
|
|
|
|
|
2023-05-04 03:19:25 +10:00
|
|
|
include_examples 'common tests'
|
2019-11-07 18:05:07 +11:00
|
|
|
|
|
|
|
it 'does not allow the moved account to follow themselves' do
|
|
|
|
source_account.follow!(target_account)
|
|
|
|
subject.perform(source_account.id, target_account.id)
|
|
|
|
expect(target_account.following?(target_account)).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|