2023-02-22 11:55:31 +11:00
# frozen_string_literal: true
2022-02-10 10:15:30 +11:00
require 'rails_helper'
2022-04-07 05:01:02 +10:00
def poll_option_json ( name , votes )
{ type : 'Note' , name : name , replies : { type : 'Collection' , totalItems : votes } }
end
2022-02-10 10:15:30 +11:00
RSpec . describe ActivityPub :: ProcessStatusUpdateService , type : :service do
2023-02-20 15:24:14 +11:00
subject { described_class . new }
2022-02-10 10:15:30 +11:00
let! ( :status ) { Fabricate ( :status , text : 'Hello world' , account : Fabricate ( :account , domain : 'example.com' ) ) }
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
summary : 'Show more' ,
content : 'Hello universe' ,
updated : '2021-09-08T22:39:25Z' ,
tag : [
{ type : 'Hashtag' , name : 'hoge' } ,
{ type : 'Mention' , href : ActivityPub :: TagManager . instance . uri_for ( alice ) } ,
] ,
}
end
let ( :json ) { Oj . load ( Oj . dump ( payload ) ) }
2023-02-20 13:17:41 +11:00
let ( :alice ) { Fabricate ( :account ) }
let ( :bob ) { Fabricate ( :account ) }
let ( :mentions ) { [ ] }
let ( :tags ) { [ ] }
let ( :media_attachments ) { [ ] }
before do
mentions . each { | a | Fabricate ( :mention , status : status , account : a ) }
tags . each { | t | status . tags << t }
media_attachments . each { | m | status . media_attachments << m }
end
2022-02-10 10:15:30 +11:00
describe '#call' do
it 'updates text' do
subject . call ( status , json )
expect ( status . reload . text ) . to eq 'Hello universe'
end
it 'updates content warning' do
subject . call ( status , json )
expect ( status . reload . spoiler_text ) . to eq 'Show more'
end
2022-04-07 05:01:02 +10:00
context 'when the changes are only in sanitized-out HTML' do
let! ( :status ) { Fabricate ( :status , text : '<p>Hello world <a href="https://joinmastodon.org" rel="nofollow">joinmastodon.org</a></p>' , account : Fabricate ( :account , domain : 'example.com' ) ) }
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
updated : '2021-09-08T22:39:25Z' ,
content : '<p>Hello world <a href="https://joinmastodon.org" rel="noreferrer">joinmastodon.org</a></p>' ,
}
end
before do
subject . call ( status , json )
end
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . edited? ) . to be false
end
end
context 'when the status has not been explicitly edited' do
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
content : 'Updated text' ,
}
end
before do
subject . call ( status , json )
end
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . reload . edited? ) . to be false
end
it 'does not update the text' do
expect ( status . reload . text ) . to eq 'Hello world'
end
end
context 'when the status has not been explicitly edited and features a poll' do
2023-02-18 08:56:20 +11:00
let ( :account ) { Fabricate ( :account , domain : 'example.com' ) }
2022-04-07 05:01:02 +10:00
let! ( :expiration ) { 10 . days . from_now . utc }
let! ( :status ) do
Fabricate ( :status ,
2023-02-18 08:56:20 +11:00
text : 'Hello world' ,
account : account ,
poll_attributes : {
options : %w( Foo Bar ) ,
account : account ,
multiple : false ,
hide_totals : false ,
2023-02-19 01:33:41 +11:00
expires_at : expiration ,
2023-02-18 08:56:20 +11:00
} )
2022-04-07 05:01:02 +10:00
end
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'https://example.com/foo' ,
type : 'Question' ,
content : 'Hello world' ,
endTime : expiration . iso8601 ,
oneOf : [
poll_option_json ( 'Foo' , 4 ) ,
poll_option_json ( 'Bar' , 3 ) ,
] ,
}
end
before do
subject . call ( status , json )
end
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . reload . edited? ) . to be false
end
it 'does not update the text' do
expect ( status . reload . text ) . to eq 'Hello world'
end
it 'updates tallies' do
expect ( status . poll . reload . cached_tallies ) . to eq [ 4 , 3 ]
end
end
context 'when the status changes a poll despite being not explicitly marked as updated' do
2023-02-18 08:56:20 +11:00
let ( :account ) { Fabricate ( :account , domain : 'example.com' ) }
2022-04-07 05:01:02 +10:00
let! ( :expiration ) { 10 . days . from_now . utc }
let! ( :status ) do
Fabricate ( :status ,
2023-02-18 08:56:20 +11:00
text : 'Hello world' ,
account : account ,
poll_attributes : {
options : %w( Foo Bar ) ,
account : account ,
multiple : false ,
hide_totals : false ,
2023-02-19 01:33:41 +11:00
expires_at : expiration ,
2023-02-18 08:56:20 +11:00
} )
2022-04-07 05:01:02 +10:00
end
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'https://example.com/foo' ,
type : 'Question' ,
content : 'Hello world' ,
endTime : expiration . iso8601 ,
oneOf : [
poll_option_json ( 'Foo' , 4 ) ,
poll_option_json ( 'Bar' , 3 ) ,
poll_option_json ( 'Baz' , 3 ) ,
] ,
}
end
before do
subject . call ( status , json )
end
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . reload . edited? ) . to be false
end
it 'does not update the text' do
expect ( status . reload . text ) . to eq 'Hello world'
end
it 'does not update tallies' do
expect ( status . poll . reload . cached_tallies ) . to eq [ 0 , 0 ]
end
end
context 'when receiving an edit older than the latest processed' do
before do
status . snapshot! ( at_time : status . created_at , rate_limit : false )
status . update! ( text : 'Hello newer world' , edited_at : Time . now . utc )
status . snapshot! ( rate_limit : false )
end
it 'does not create any edits' do
2023-02-20 12:33:27 +11:00
expect { subject . call ( status , json ) } . to_not change { status . reload . edits . pluck ( & :id ) }
2022-04-07 05:01:02 +10:00
end
it 'does not update the text, spoiler_text or edited_at' do
2023-02-20 12:33:27 +11:00
expect { subject . call ( status , json ) } . to_not change { s = status . reload ; [ s . text , s . spoiler_text , s . edited_at ] }
2022-04-07 05:01:02 +10:00
end
end
2022-03-26 10:38:44 +11:00
context 'with no changes at all' do
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
content : 'Hello world' ,
}
end
before do
subject . call ( status , json )
end
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . edited? ) . to be false
end
end
2022-03-13 05:33:10 +11:00
context 'with no changes and originally with no ordered_media_attachment_ids' do
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
content : 'Hello world' ,
}
end
before do
status . update ( ordered_media_attachment_ids : nil )
subject . call ( status , json )
end
2022-03-26 10:38:44 +11:00
it 'does not create any edits' do
expect ( status . reload . edits ) . to be_empty
end
it 'does not mark status as edited' do
expect ( status . edited? ) . to be false
2022-03-13 05:33:10 +11:00
end
end
2023-05-04 13:49:08 +10:00
context 'when originally without tags' do
2022-02-10 10:15:30 +11:00
before do
subject . call ( status , json )
end
it 'updates tags' do
expect ( status . tags . reload . map ( & :name ) ) . to eq %w( hoge )
end
end
2023-05-04 13:49:08 +10:00
context 'when originally with tags' do
2022-02-10 10:15:30 +11:00
let ( :tags ) { [ Fabricate ( :tag , name : 'test' ) , Fabricate ( :tag , name : 'foo' ) ] }
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
summary : 'Show more' ,
content : 'Hello universe' ,
updated : '2021-09-08T22:39:25Z' ,
tag : [
{ type : 'Hashtag' , name : 'foo' } ,
] ,
}
end
before do
subject . call ( status , json )
end
it 'updates tags' do
expect ( status . tags . reload . map ( & :name ) ) . to eq %w( foo )
end
end
2023-05-04 13:49:08 +10:00
context 'when originally without mentions' do
2022-02-10 10:15:30 +11:00
before do
subject . call ( status , json )
end
it 'updates mentions' do
expect ( status . active_mentions . reload . map ( & :account_id ) ) . to eq [ alice . id ]
end
end
2023-05-04 13:49:08 +10:00
context 'when originally with mentions' do
2022-02-10 10:15:30 +11:00
let ( :mentions ) { [ alice , bob ] }
before do
subject . call ( status , json )
end
it 'updates mentions' do
expect ( status . active_mentions . reload . map ( & :account_id ) ) . to eq [ alice . id ]
end
end
2023-05-04 13:49:08 +10:00
context 'when originally without media attachments' do
2022-02-10 10:15:30 +11:00
before do
2022-11-28 06:39:05 +11:00
stub_request ( :get , 'https://example.com/foo.png' ) . to_return ( body : attachment_fixture ( 'emojo.png' ) )
2022-02-10 10:15:30 +11:00
subject . call ( status , json )
end
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
content : 'Hello universe' ,
updated : '2021-09-08T22:39:25Z' ,
attachment : [
{ type : 'Image' , mediaType : 'image/png' , url : 'https://example.com/foo.png' } ,
2023-02-19 01:33:41 +11:00
] ,
2022-02-10 10:15:30 +11:00
}
end
it 'updates media attachments' do
2022-03-09 19:06:17 +11:00
media_attachment = status . reload . ordered_media_attachments . first
2022-02-10 10:15:30 +11:00
expect ( media_attachment ) . to_not be_nil
expect ( media_attachment . remote_url ) . to eq 'https://example.com/foo.png'
end
2022-11-28 06:39:05 +11:00
it 'fetches the attachment' do
expect ( a_request ( :get , 'https://example.com/foo.png' ) ) . to have_been_made
2022-02-10 10:15:30 +11:00
end
it 'records media change in edit' do
2022-03-09 19:06:17 +11:00
expect ( status . edits . reload . last . ordered_media_attachment_ids ) . to_not be_empty
2022-02-10 10:15:30 +11:00
end
end
2023-05-04 13:49:08 +10:00
context 'when originally with media attachments' do
2022-02-10 10:15:30 +11:00
let ( :media_attachments ) { [ Fabricate ( :media_attachment , remote_url : 'https://example.com/foo.png' ) , Fabricate ( :media_attachment , remote_url : 'https://example.com/unused.png' ) ] }
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Note' ,
content : 'Hello universe' ,
updated : '2021-09-08T22:39:25Z' ,
attachment : [
{ type : 'Image' , mediaType : 'image/png' , url : 'https://example.com/foo.png' , name : 'A picture' } ,
2023-02-19 01:33:41 +11:00
] ,
2022-02-10 10:15:30 +11:00
}
end
before do
allow ( RedownloadMediaWorker ) . to receive ( :perform_async )
subject . call ( status , json )
end
it 'updates the existing media attachment in-place' do
media_attachment = status . media_attachments . reload . first
expect ( media_attachment ) . to_not be_nil
expect ( media_attachment . remote_url ) . to eq 'https://example.com/foo.png'
expect ( media_attachment . description ) . to eq 'A picture'
end
it 'does not queue redownload for the existing media attachment' do
expect ( RedownloadMediaWorker ) . to_not have_received ( :perform_async )
end
it 'updates media attachments' do
2022-03-09 19:06:17 +11:00
expect ( status . ordered_media_attachments . map ( & :remote_url ) ) . to eq %w( https://example.com/foo.png )
2022-02-10 10:15:30 +11:00
end
it 'records media change in edit' do
2022-03-09 19:06:17 +11:00
expect ( status . edits . reload . last . ordered_media_attachment_ids ) . to_not be_empty
2022-02-10 10:15:30 +11:00
end
end
2023-05-04 13:49:08 +10:00
context 'when originally with a poll' do
2022-02-10 10:15:30 +11:00
before do
poll = Fabricate ( :poll , status : status )
status . update ( preloadable_poll : poll )
subject . call ( status , json )
end
it 'removes poll' do
2023-02-20 16:14:50 +11:00
expect ( status . reload . poll ) . to be_nil
2022-02-10 10:15:30 +11:00
end
it 'records media change in edit' do
2022-03-09 19:06:17 +11:00
expect ( status . edits . reload . last . poll_options ) . to be_nil
2022-02-10 10:15:30 +11:00
end
end
2023-05-04 13:49:08 +10:00
context 'when originally without a poll' do
2022-02-10 10:15:30 +11:00
let ( :payload ) do
{
'@context' : 'https://www.w3.org/ns/activitystreams' ,
id : 'foo' ,
type : 'Question' ,
content : 'Hello universe' ,
updated : '2021-09-08T22:39:25Z' ,
closed : true ,
oneOf : [
{ type : 'Note' , name : 'Foo' } ,
{ type : 'Note' , name : 'Bar' } ,
{ type : 'Note' , name : 'Baz' } ,
] ,
}
end
before do
subject . call ( status , json )
end
it 'creates a poll' do
poll = status . reload . poll
expect ( poll ) . to_not be_nil
expect ( poll . options ) . to eq %w( Foo Bar Baz )
end
it 'records media change in edit' do
2022-03-09 19:06:17 +11:00
expect ( status . edits . reload . last . poll_options ) . to eq %w( Foo Bar Baz )
2022-02-10 10:15:30 +11:00
end
end
it 'creates edit history' do
subject . call ( status , json )
expect ( status . edits . reload . map ( & :text ) ) . to eq [ 'Hello world' , 'Hello universe' ]
end
it 'sets edited timestamp' do
subject . call ( status , json )
expect ( status . reload . edited_at . to_s ) . to eq '2021-09-08 22:39:25 UTC'
end
end
end