2023-02-22 11:55:31 +11:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
Add moderation warnings (#9519)
* Add moderation warnings
Replace individual routes for disabling, silencing, and suspending
a user, as well as the report update route, with a unified account
action controller that allows you to select an action (none,
disable, silence, suspend) as well as whether it should generate an
e-mail notification with optional custom text. That notification,
with the optional custom text, is saved as a warning.
Additionally, there are warning presets you can configure to save
time when performing the above.
* Use Account#local_username_and_domain
2018-12-23 06:02:09 +11:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2023-05-04 13:49:53 +10:00
|
|
|
RSpec.describe Admin::AccountAction do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:account_action) { described_class.new }
|
|
|
|
|
|
|
|
describe '#save!' do
|
|
|
|
subject { account_action.save! }
|
2023-02-20 12:46:00 +11:00
|
|
|
|
2022-07-05 10:41:40 +10:00
|
|
|
let(:account) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')).account }
|
2022-01-28 10:46:42 +11:00
|
|
|
let(:target_account) { Fabricate(:account) }
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:type) { 'disable' }
|
|
|
|
|
|
|
|
before do
|
|
|
|
account_action.assign_attributes(
|
2023-02-20 16:58:28 +11:00
|
|
|
type: type,
|
2019-01-11 18:26:03 +11:00
|
|
|
current_account: account,
|
2023-02-20 16:58:28 +11:00
|
|
|
target_account: target_account
|
2019-01-11 18:26:03 +11:00
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when type is "disable"' do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:type) { 'disable' }
|
|
|
|
|
|
|
|
it 'disable user' do
|
|
|
|
subject
|
|
|
|
expect(target_account.user).to be_disabled
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when type is "silence"' do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:type) { 'silence' }
|
|
|
|
|
|
|
|
it 'silences account' do
|
|
|
|
subject
|
|
|
|
expect(target_account).to be_silenced
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when type is "suspend"' do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:type) { 'suspend' }
|
|
|
|
|
|
|
|
it 'suspends account' do
|
|
|
|
subject
|
|
|
|
expect(target_account).to be_suspended
|
|
|
|
end
|
|
|
|
|
2024-01-10 22:06:58 +11:00
|
|
|
it 'queues Admin::SuspensionWorker by 1' do
|
2023-11-23 20:43:43 +11:00
|
|
|
expect do
|
|
|
|
subject
|
|
|
|
end.to change { Admin::SuspensionWorker.jobs.size }.by 1
|
2019-01-11 18:26:03 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-06-14 23:21:36 +10:00
|
|
|
context 'when type is invalid' do
|
|
|
|
let(:type) { 'whatever' }
|
|
|
|
|
|
|
|
it 'raises an invalid record error' do
|
|
|
|
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when type is not given' do
|
|
|
|
let(:type) { '' }
|
|
|
|
|
|
|
|
it 'raises an invalid record error' do
|
|
|
|
expect { subject }.to raise_error(ActiveRecord::RecordInvalid)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2024-04-26 03:26:05 +10:00
|
|
|
it 'sends notification, log the action, and closes other reports', :aggregate_failures do
|
|
|
|
other_report = Fabricate(:report, target_account: target_account)
|
2019-01-11 18:26:03 +11:00
|
|
|
|
2024-04-26 03:26:05 +10:00
|
|
|
emails = []
|
|
|
|
expect do
|
|
|
|
emails = capture_emails { subject }
|
|
|
|
end.to (change(Admin::ActionLog.where(action: type), :count).by 1)
|
|
|
|
.and(change { other_report.reload.action_taken? }.from(false).to(true))
|
|
|
|
|
|
|
|
expect(emails).to contain_exactly(
|
|
|
|
have_attributes(
|
|
|
|
to: contain_exactly(target_account.user.email)
|
|
|
|
)
|
|
|
|
)
|
2019-01-11 18:26:03 +11:00
|
|
|
|
2024-04-26 03:26:05 +10:00
|
|
|
expect(LocalNotificationWorker).to have_enqueued_sidekiq_job(target_account.id, anything, 'AccountWarning', 'moderation_warning')
|
2019-01-11 18:26:03 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#report' do
|
|
|
|
subject { account_action.report }
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'with report_id.present?' do
|
2019-01-11 18:26:03 +11:00
|
|
|
before do
|
|
|
|
account_action.report_id = Fabricate(:report).id
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns Report' do
|
|
|
|
expect(subject).to be_instance_of Report
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'with !report_id.present?' do
|
2019-01-11 18:26:03 +11:00
|
|
|
it 'returns nil' do
|
|
|
|
expect(subject).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#with_report?' do
|
|
|
|
subject { account_action.with_report? }
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'with !report.nil?' do
|
2019-01-11 18:26:03 +11:00
|
|
|
before do
|
|
|
|
account_action.report_id = Fabricate(:report).id
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true' do
|
|
|
|
expect(subject).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'with !(!report.nil?)' do
|
2019-01-11 18:26:03 +11:00
|
|
|
it 'returns false' do
|
|
|
|
expect(subject).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.types_for_account' do
|
|
|
|
subject { described_class.types_for_account(account) }
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'when Account.local?' do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:account) { Fabricate(:account, domain: nil) }
|
|
|
|
|
2020-11-05 06:45:01 +11:00
|
|
|
it 'returns ["none", "disable", "sensitive", "silence", "suspend"]' do
|
|
|
|
expect(subject).to eq %w(none disable sensitive silence suspend)
|
2019-01-11 18:26:03 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-05-04 13:49:08 +10:00
|
|
|
context 'with !account.local?' do
|
2019-01-11 18:26:03 +11:00
|
|
|
let(:account) { Fabricate(:account, domain: 'hoge.com') }
|
|
|
|
|
2020-11-05 06:45:01 +11:00
|
|
|
it 'returns ["sensitive", "silence", "suspend"]' do
|
|
|
|
expect(subject).to eq %w(sensitive silence suspend)
|
2019-01-11 18:26:03 +11:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
Add moderation warnings (#9519)
* Add moderation warnings
Replace individual routes for disabling, silencing, and suspending
a user, as well as the report update route, with a unified account
action controller that allows you to select an action (none,
disable, silence, suspend) as well as whether it should generate an
e-mail notification with optional custom text. That notification,
with the optional custom text, is saved as a warning.
Additionally, there are warning presets you can configure to save
time when performing the above.
* Use Account#local_username_and_domain
2018-12-23 06:02:09 +11:00
|
|
|
end
|