Merge tag 'v4.3.0-rc.1'

This commit is contained in:
Mike Barnes 2024-10-02 10:34:27 +10:00
commit 26c9b9ba39
3459 changed files with 130932 additions and 69993 deletions

View file

@ -2,11 +2,11 @@
require 'rails_helper'
describe NoteLengthValidator do
RSpec.describe NoteLengthValidator do
subject { described_class.new(attributes: { note: true }, maximum: 640) }
describe '#validate' do
it 'adds an error when text is over 640 characters' do
it 'adds an error when text is over configured character limit' do
text = 'a' * 650
account = instance_double(Account, note: text, errors: activemodel_errors)
@ -14,16 +14,16 @@ describe NoteLengthValidator do
expect(account.errors).to have_received(:add)
end
it 'counts URLs as 23 characters flat' do
text = ('a' * 476) + " http://#{'b' * 30}.com/example"
it 'reduces calculated length of auto-linkable space-separated URLs' do
text = [starting_string, example_link].join(' ')
account = instance_double(Account, note: text, errors: activemodel_errors)
subject.validate_each(account, 'note', text)
expect(account.errors).to_not have_received(:add)
end
it 'does not count non-autolinkable URLs as 23 characters flat' do
text = ('a' * 476) + "http://#{'b' * 30}.com/example"
it 'does not reduce calculated length of non-autolinkable URLs' do
text = [starting_string, example_link].join
account = instance_double(Account, note: text, errors: activemodel_errors)
subject.validate_each(account, 'note', text)
@ -32,6 +32,14 @@ describe NoteLengthValidator do
private
def starting_string
'a' * 476
end
def example_link
"http://#{'b' * 30}.com/example"
end
def activemodel_errors
instance_double(ActiveModel::Errors, add: nil)
end