chinwag/chinwagsocial
chinwag/chinwagsocial
2
0
Fork 0
Code Issues Pull requests Releases 4 Wiki Activity

Change alt text to empty string for avatars (#21875)

Browse source 
Co-authored-by: Renaud Chaput <renchap@gmail.com>
This commit is contained in:
Jasmin Johal 2023-11-07 13:46:08 -08:00 committed by GitHub
parent 58f01a5c9a
commit 27cbdc6f22
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/helpers/admin/account_moderation_notes_helper.rb
View file

@ -6,7 +6,7 @@ module Admin::AccountModerationNotesHelper
link_to path || admin_account_path(account.id), class: name_tag_classes(account), title: account.acct do link_to path || admin_account_path(account.id), class: name_tag_classes(account), title: account.acct do
safe_join([ safe_join([
image_tag(account.avatar.url, width: 15, height: 15, alt: display_name(account), class: 'avatar'), image_tag(account.avatar.url, width: 15, height: 15, alt: '', class: 'avatar'),
content_tag(:span, account.acct, class: 'username'), content_tag(:span, account.acct, class: 'username'),
], ' ') ], ' ')
end end

2
app/helpers/settings_helper.rb
View file

@ -25,7 +25,7 @@ module SettingsHelper
return if account.nil? return if account.nil?
link_to ActivityPub::TagManager.instance.url_for(account), class: 'name-tag', title: account.acct do link_to ActivityPub::TagManager.instance.url_for(account), class: 'name-tag', title: account.acct do
safe_join([image_tag(account.avatar.url, width: 15, height: 15, alt: display_name(account), class: 'avatar'), content_tag(:span, account.acct, class: 'username')], ' ') safe_join([image_tag(account.avatar.url, width: 15, height: 15, alt: '', class: 'avatar'), content_tag(:span, account.acct, class: 'username')], ' ')
end end
end end
end end

4
app/javascript/mastodon/components/__tests__/__snapshots__/avatar-test.jsx.snap
View file

@ -13,7 +13,7 @@ exports[`<Avatar /> Autoplay renders a animated avatar 1`] = `
} }
> >
<img <img
alt="alice" alt=""
src="/animated/alice.gif" src="/animated/alice.gif"
/> />
</div> </div>
@ -32,7 +32,7 @@ exports[`<Avatar /> Still renders a still avatar 1`] = `
} }
> >
<img <img
alt="alice" alt=""
src="/static/alice.jpg" src="/static/alice.jpg"
/> />
</div> </div>

2
app/javascript/mastodon/components/avatar.tsx
View file

@ -42,7 +42,7 @@ export const Avatar: React.FC<Props> = ({
onMouseLeave={handleMouseLeave} onMouseLeave={handleMouseLeave}
style={style} style={style}
> >
{src && <img src={src} alt={account?.get('acct')} />} {src && <img src={src} alt='' />}
</div> </div>
); );
}; };

2
app/javascript/mastodon/features/account_timeline/containers/header_container.jsx
View file

@ -178,7 +178,7 @@ const mapDispatchToProps = (dispatch, { intl }) => ({
modalType: 'IMAGE', modalType: 'IMAGE',
modalProps: { modalProps: {
src: account.get('avatar'), src: account.get('avatar'),
alt: account.get('acct'), alt: '',
}, },
})); }));
}, },

2
app/views/filters/statuses/_status_filter.html.haml
View file

@ -20,7 +20,7 @@
.detailed-status__meta .detailed-status__meta
= link_to ActivityPub::TagManager.instance.url_for(status.account), class: 'name-tag', target: '_blank', rel: 'noopener noreferrer' do = link_to ActivityPub::TagManager.instance.url_for(status.account), class: 'name-tag', target: '_blank', rel: 'noopener noreferrer' do
= image_tag(status.account.avatar.url, width: 15, height: 15, alt: display_name(status.account), class: 'avatar') = image_tag(status.account.avatar.url, width: 15, height: 15, alt: '', class: 'avatar')
.username= status.account.acct .username= status.account.acct
· ·
= link_to ActivityPub::TagManager.instance.url_for(status), class: 'detailed-status__datetime', target: stream_link_target, rel: 'noopener noreferrer' do = link_to ActivityPub::TagManager.instance.url_for(status), class: 'detailed-status__datetime', target: stream_link_target, rel: 'noopener noreferrer' do