Fix grouping across hourly buckets happening in a 12 seconds window instead of 12 hours window (#31062)

This commit is contained in:
Claire 2024-07-18 17:23:40 +02:00 committed by GitHub
parent f587ff643f
commit 6e47637dd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -217,7 +217,7 @@ class NotifyService < BaseService
hour_bucket = previous_bucket if hour_bucket < previous_bucket + MAXIMUM_GROUP_SPAN_HOURS hour_bucket = previous_bucket if hour_bucket < previous_bucket + MAXIMUM_GROUP_SPAN_HOURS
# We do not concern ourselves with race conditions since we use hour buckets # We do not concern ourselves with race conditions since we use hour buckets
redis.set(redis_key, hour_bucket, ex: MAXIMUM_GROUP_SPAN_HOURS) redis.set(redis_key, hour_bucket, ex: MAXIMUM_GROUP_SPAN_HOURS.hours.to_i)
"#{type_prefix}-#{hour_bucket}" "#{type_prefix}-#{hour_bucket}"
end end