Fix race conditions on account migration creation (#15597)
* Atomically check for processing lock in Move handler * Prevent race condition when creating account migrations Fixes #15595 * Add tests Co-authored-by: Claire <claire.github-309c@sitedethib.com>
This commit is contained in:
		
					parent
					
						
							
								c8d11b8bdb
							
						
					
				
			
			
				commit
				
					
						a044ddac5b
					
				
			
		
					 4 changed files with 127 additions and 34 deletions
				
			
		|  | @ -14,6 +14,8 @@ | |||
| # | ||||
| 
 | ||||
| class AccountMigration < ApplicationRecord | ||||
|   include Redisable | ||||
| 
 | ||||
|   COOLDOWN_PERIOD = 30.days.freeze | ||||
| 
 | ||||
|   belongs_to :account | ||||
|  | @ -39,7 +41,13 @@ class AccountMigration < ApplicationRecord | |||
| 
 | ||||
|     return false unless errors.empty? | ||||
| 
 | ||||
|     save | ||||
|     RedisLock.acquire(lock_options) do |lock| | ||||
|       if lock.acquired? | ||||
|         save | ||||
|       else | ||||
|         raise Mastodon::RaceConditionError | ||||
|       end | ||||
|     end | ||||
|   end | ||||
| 
 | ||||
|   def cooldown_at | ||||
|  | @ -75,4 +83,8 @@ class AccountMigration < ApplicationRecord | |||
|   def validate_migration_cooldown | ||||
|     errors.add(:base, I18n.t('migrations.errors.on_cooldown')) if account.migrations.within_cooldown.exists? | ||||
|   end | ||||
| 
 | ||||
|   def lock_options | ||||
|     { redis: redis, key: "account_migration:#{account.id}" } | ||||
|   end | ||||
| end | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue