chinwag/chinwagsocial
chinwag/chinwagsocial
2
0
Fork 0
Code Issues Pull requests Releases 14 Wiki Activity

Add workaround for YouTube Shorts links (#17869)

Browse source 
* Add workaround for YouTube Shorts links

* Update link_details_extractor_spec.rb
This commit is contained in:
Eugen Rochko 2022-03-25 19:31:35 +01:00 • committed by GitHub
commit b58db8f12e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/lib/link_details_extractor.rb
View file

@ -208,7 +208,7 @@ class LinkDetailsExtractor
end
def valid_url_or_nil(str, same_origin_only: false)
return if str.blank?
return if str.blank? || str == 'null'
url = @original_url + Addressable::URI.parse(str)

8
spec/lib/link_details_extractor_spec.rb
View file

@ -25,6 +25,14 @@ RSpec.describe LinkDetailsExtractor do
expect(subject.canonical_url).to eq 'https://foo.com/article'
end
end
context 'when canonical URL is set to "null"' do
let(:html) { '<!doctype html><link rel="canonical" href="null" />' }
it 'ignores the canonical URLs' do
expect(subject.canonical_url).to eq original_url
end
end
end
context 'when structured data is present' do