chinwag/chinwagsocial
chinwag/chinwagsocial
2
0
Fork 0
Code Issues Pull requests Releases 14 Wiki Activity

Use preview image in <ImageLoader /> to provide immediate visual feedback (#3595)

Browse source 
before the full-size image is loaded
This commit is contained in:
Eugen Rochko 2017-06-06 19:30:17 +02:00 • committed by GitHub
commit b623dd12c1
3 changed files with 44 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

37
app/javascript/mastodon/features/ui/components/image_loader.js
View file

@ -5,6 +5,9 @@ class ImageLoader extends React.PureComponent {
static propTypes = {
src: PropTypes.string.isRequired,
previewSrc: PropTypes.string.isRequired,
width: PropTypes.number.isRequired,
height: PropTypes.number.isRequired,
}
state = {
@ -13,31 +16,45 @@ class ImageLoader extends React.PureComponent {
}
componentWillMount() {
this.loadImage(this.props.src);
this._loadImage(this.props.src);
}
componentWillReceiveProps(props) {
this.loadImage(props.src);
this._loadImage(props.src);
}
loadImage(src) {
_loadImage(src) {
const image = new Image();
image.onerror = () => this.setState({ loading: false, error: true });
image.onload = () => this.setState({ loading: false, error: false });
image.onload = () => this.setState({ loading: false, error: false });
image.src = src;
this.lastSrc = src;
this.setState({ loading: true });
}
render() {
const { src } = this.props;
const { src, previewSrc, width, height } = this.props;
const { loading, error } = this.state;
// TODO: handle image error state
return (
<div className='image-loader'>
<img // eslint-disable-line jsx-a11y/img-has-alt
className='image-loader__img'
src={src}
width={width}
height={height}
/>
const imageClass = `image-loader__img ${loading ? 'image-loader__img-loading' : ''}`;
return <img className={imageClass} src={src} />; // eslint-disable-line jsx-a11y/img-has-alt
{loading &&
<img // eslint-disable-line jsx-a11y/img-has-alt
src={previewSrc}
className='image-loader__preview-img'
/>
}
</div>
);
}
}

2
app/javascript/mastodon/features/ui/components/media_modal.js
View file

@ -73,7 +73,7 @@ class MediaModal extends ImmutablePureComponent {
}
if (attachment.get('type') === 'image') {
content = <ImageLoader src={url} />;
content = <ImageLoader previewSrc={attachment.get('preview_url')} src={url} width={attachment.getIn(['meta', 'original', 'width'])} height={attachment.getIn(['meta', 'original', 'height'])} />;
} else if (attachment.get('type') === 'gifv') {
content = <ExtendedVideoPlayer src={url} muted controls={false} />;
}