chinwagsocial/spec
Claire 0a120d86d2
Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search

While this code seems to not present an actual vulnerability, one could
easily be introduced by mistake due to how the query is built.

This PR parameterises the `to_tsquery` input to make the query more robust.

* Harden code for Status#tagged_with_all and Status#tagged_with_none

Those two scopes aren't used in a way that could be vulnerable to an SQL
injection, but keeping them unchanged might be a hazard.

* Remove unneeded spaces surrounding tsquery term

* Please CodeClimate

* Move advanced_search_for SQL template to its own function

This avoids one level of indentation while making clearer that the SQL template
isn't build from all the dynamic parameters of advanced_search_for.

* Add tests covering tagged_with, tagged_with_all and tagged_with_none

* Rewrite tagged_with_none to avoid multiple joins and make it more robust

* Remove obsolete brakeman warnings

* Revert "Remove unneeded spaces surrounding tsquery term"

The two queries are not strictly equivalent.

This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.
2022-01-23 18:10:10 +01:00
..
controllers Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
fabricators Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
features Add submit button to the top of preferences pages (#13068) 2020-03-08 16:04:03 +01:00
fixtures Fix some link previews being incorrectly generated from other prior links (#16885) 2021-10-21 20:39:35 +02:00
helpers Add trending links (#16917) 2021-11-25 13:07:38 +01:00
lib Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
mailers Add notifications for statuses deleted by moderators (#17204) 2022-01-17 09:41:33 +01:00
models Fix error-prone SQL queries (#15828) 2022-01-23 18:10:10 +01:00
policies Add ability for admins to delete canonical email blocks (#16644) 2021-12-17 23:02:14 +01:00
presenters Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 2021-07-13 15:46:20 +02:00
requests Further preparation for Rails 6 (#15916) 2021-03-19 02:45:34 +01:00
routing Move create/destroy actions for api/v1/statuses to namespace (#3678) 2017-06-10 09:39:26 +02:00
serializers/activitypub Fix account URI in UpdatePollSerializer (#11194) 2019-06-27 19:41:55 +02:00
services Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
support Fix base64-encoded file uploads not being possible (#12748) 2020-01-04 01:54:07 +01:00
validators Add support for private pinned posts (#16954) 2022-01-17 00:49:55 +01:00
views Fix error when rendering public pages with media attachments (#16763) 2021-10-13 15:27:19 +02:00
workers Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
rails_helper.rb Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
spec_helper.rb Move rspec examples to tmp dir (#12539) 2019-12-02 19:55:08 +01:00