41eeb9ebaa
DISTINCT clause removes duplicated records according to all the selected attributes. In reality, it can remove duplicated records only looking at statuses.id, but the clause confuses the query planner and yields insufficient performance. The behavior is also problematic if the scope produced by HashQueryService is used to query columns without id (using pluck method, for example). The scope is expected to contain unique statuses, but the uniquness will be evaluated with some arbitrary columns other than id. GROUP BY clause resolves those problem by explicitly specifying the column to take into account for the record distinction. A workaround for the problem of DISTINCT clause in Api::V1::Timelines::TagController is no longer necessary and removed.
71 lines
1.6 KiB
Ruby
71 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Api::V1::Timelines::TagController < Api::BaseController
|
|
before_action :load_tag
|
|
after_action :insert_pagination_headers, unless: -> { @statuses.empty? }
|
|
|
|
def show
|
|
@statuses = load_statuses
|
|
render json: @statuses, each_serializer: REST::StatusSerializer, relationships: StatusRelationshipsPresenter.new(@statuses, current_user&.account_id)
|
|
end
|
|
|
|
private
|
|
|
|
def load_tag
|
|
@tag = Tag.find_normalized(params[:id])
|
|
end
|
|
|
|
def load_statuses
|
|
cached_tagged_statuses
|
|
end
|
|
|
|
def cached_tagged_statuses
|
|
cache_collection tagged_statuses, Status
|
|
end
|
|
|
|
def tagged_statuses
|
|
if @tag.nil?
|
|
[]
|
|
else
|
|
statuses = tag_timeline_statuses.paginate_by_id(
|
|
limit_param(DEFAULT_STATUSES_LIMIT),
|
|
params_slice(:max_id, :since_id, :min_id)
|
|
)
|
|
|
|
if truthy_param?(:only_media)
|
|
statuses.joins(:media_attachments)
|
|
else
|
|
statuses
|
|
end
|
|
end
|
|
end
|
|
|
|
def tag_timeline_statuses
|
|
HashtagQueryService.new.call(@tag, params.slice(:any, :all, :none), current_account, truthy_param?(:local))
|
|
end
|
|
|
|
def insert_pagination_headers
|
|
set_pagination_headers(next_path, prev_path)
|
|
end
|
|
|
|
def pagination_params(core_params)
|
|
params.slice(:local, :limit, :only_media).permit(:local, :limit, :only_media).merge(core_params)
|
|
end
|
|
|
|
def next_path
|
|
api_v1_timelines_tag_url params[:id], pagination_params(max_id: pagination_max_id)
|
|
end
|
|
|
|
def prev_path
|
|
api_v1_timelines_tag_url params[:id], pagination_params(min_id: pagination_since_id)
|
|
end
|
|
|
|
def pagination_max_id
|
|
@statuses.last.id
|
|
end
|
|
|
|
def pagination_since_id
|
|
@statuses.first.id
|
|
end
|
|
end
|