be3b9f8151
* Fix URI of repeat follow requests not being recorded In case we receive a “repeat” or “duplicate” follow request, we automatically fast-forward the accept with the latest received Activity `id`, but we don't record it. In general, a “repeat” or “duplicate” follow request may happen if for some reason (e.g. inconsistent handling of Block or Undo Accept activities, an instance being brought back up from the dead, etc.) the local instance thought the remote actor were following them while the remote actor thought otherwise. In those cases, the remote instance does not know about the older Follow activity `id`, so keeping that record serves no purpose, but knowing the most recent one is useful if the remote implementation at some point refers to it by `id` without inlining it. * Add tests
46 lines
1.8 KiB
Ruby
46 lines
1.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ActivityPub::Activity::Follow < ActivityPub::Activity
|
|
include Payloadable
|
|
|
|
def perform
|
|
target_account = account_from_uri(object_uri)
|
|
|
|
return if target_account.nil? || !target_account.local? || delete_arrived_first?(@json['id'])
|
|
|
|
# Update id of already-existing follow requests
|
|
existing_follow_request = ::FollowRequest.find_by(account: @account, target_account: target_account)
|
|
unless existing_follow_request.nil?
|
|
existing_follow_request.update!(uri: @json['id'])
|
|
return
|
|
end
|
|
|
|
if target_account.blocking?(@account) || target_account.domain_blocking?(@account.domain) || target_account.moved? || target_account.instance_actor?
|
|
reject_follow_request!(target_account)
|
|
return
|
|
end
|
|
|
|
# Fast-forward repeat follow requests
|
|
existing_follow = ::Follow.find_by(account: @account, target_account: target_account)
|
|
unless existing_follow.nil?
|
|
existing_follow.update!(uri: @json['id'])
|
|
AuthorizeFollowService.new.call(@account, target_account, skip_follow_request: true, follow_request_uri: @json['id'])
|
|
return
|
|
end
|
|
|
|
follow_request = FollowRequest.create!(account: @account, target_account: target_account, uri: @json['id'])
|
|
|
|
if target_account.locked? || @account.silenced?
|
|
NotifyService.new.call(target_account, :follow_request, follow_request)
|
|
else
|
|
AuthorizeFollowService.new.call(@account, target_account)
|
|
NotifyService.new.call(target_account, :follow, ::Follow.find_by(account: @account, target_account: target_account))
|
|
end
|
|
end
|
|
|
|
def reject_follow_request!(target_account)
|
|
json = Oj.dump(serialize_payload(FollowRequest.new(account: @account, target_account: target_account, uri: @json['id']), ActivityPub::RejectFollowSerializer))
|
|
ActivityPub::DeliveryWorker.perform_async(json, target_account.id, @account.inbox_url)
|
|
end
|
|
end
|