d0dd9eb5b5
* Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation
329 lines
8.7 KiB
Ruby
329 lines
8.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Api::V1::StatusesController, type: :controller do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
|
|
let(:app) { Fabricate(:application, name: 'Test app', website: 'http://testapp.com') }
|
|
let(:token) { double acceptable?: true, resource_owner_id: user.id, application: app }
|
|
|
|
context 'with an oauth token' do
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'GET #show' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
it 'returns http success' do
|
|
get :show, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #context' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :context, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #reblogged_by' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :reblog, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :reblogged_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #favourited_by' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :favourite, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :favourited_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
before do
|
|
post :create, params: { status: 'Hello world' }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'DELETE #destroy' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :destroy, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'removes the status' do
|
|
expect(Status.find_by(id: status.id)).to be nil
|
|
end
|
|
end
|
|
|
|
describe 'POST #reblog' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :reblog, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'updates the reblogs count' do
|
|
expect(status.reblogs.count).to eq 1
|
|
end
|
|
|
|
it 'updates the reblogged attribute' do
|
|
expect(user.account.reblogged?(status)).to be true
|
|
end
|
|
|
|
it 'return json with updated attributes' do
|
|
hash_body = body_as_json
|
|
|
|
expect(hash_body[:reblog][:id]).to eq status.id
|
|
expect(hash_body[:reblog][:reblogs_count]).to eq 1
|
|
expect(hash_body[:reblog][:reblogged]).to be true
|
|
end
|
|
end
|
|
|
|
describe 'POST #unreblog' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :reblog, params: { id: status.id }
|
|
post :unreblog, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'updates the reblogs count' do
|
|
expect(status.reblogs.count).to eq 0
|
|
end
|
|
|
|
it 'updates the reblogged attribute' do
|
|
expect(user.account.reblogged?(status)).to be false
|
|
end
|
|
end
|
|
|
|
describe 'POST #favourite' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :favourite, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'updates the favourites count' do
|
|
expect(status.favourites.count).to eq 1
|
|
end
|
|
|
|
it 'updates the favourited attribute' do
|
|
expect(user.account.favourited?(status)).to be true
|
|
end
|
|
|
|
it 'return json with updated attributes' do
|
|
hash_body = body_as_json
|
|
|
|
expect(hash_body[:id]).to eq status.id
|
|
expect(hash_body[:favourites_count]).to eq 1
|
|
expect(hash_body[:favourited]).to be true
|
|
end
|
|
end
|
|
|
|
describe 'POST #unfavourite' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :favourite, params: { id: status.id }
|
|
post :unfavourite, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'updates the favourites count' do
|
|
expect(status.favourites.count).to eq 0
|
|
end
|
|
|
|
it 'updates the favourited attribute' do
|
|
expect(user.account.favourited?(status)).to be false
|
|
end
|
|
end
|
|
|
|
describe 'POST #mute' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :mute, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'creates a conversation mute' do
|
|
expect(ConversationMute.find_by(account: user.account, conversation_id: status.conversation_id)).to_not be_nil
|
|
end
|
|
end
|
|
|
|
describe 'POST #unmute' do
|
|
let(:status) { Fabricate(:status, account: user.account) }
|
|
|
|
before do
|
|
post :mute, params: { id: status.id }
|
|
post :unmute, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'destroys the conversation mute' do
|
|
expect(ConversationMute.find_by(account: user.account, conversation_id: status.conversation_id)).to be_nil
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'without an oauth token' do
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { nil }
|
|
end
|
|
|
|
context 'with a private status' do
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :private) }
|
|
|
|
describe 'GET #show' do
|
|
it 'returns http unautharized' do
|
|
get :show, params: { id: status.id }
|
|
expect(response).to have_http_status(:missing)
|
|
end
|
|
end
|
|
|
|
describe 'GET #context' do
|
|
before do
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
end
|
|
|
|
it 'returns http unautharized' do
|
|
get :context, params: { id: status.id }
|
|
expect(response).to have_http_status(:missing)
|
|
end
|
|
end
|
|
|
|
describe 'GET #card' do
|
|
it 'returns http unautharized' do
|
|
get :card, params: { id: status.id }
|
|
expect(response).to have_http_status(:missing)
|
|
end
|
|
end
|
|
|
|
describe 'GET #reblogged_by' do
|
|
before do
|
|
post :reblog, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http unautharized' do
|
|
get :reblogged_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:missing)
|
|
end
|
|
end
|
|
|
|
describe 'GET #favourited_by' do
|
|
before do
|
|
post :favourite, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http unautharized' do
|
|
get :favourited_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:missing)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with a public status' do
|
|
let(:status) { Fabricate(:status, account: user.account, visibility: :public) }
|
|
|
|
describe 'GET #show' do
|
|
it 'returns http success' do
|
|
get :show, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #context' do
|
|
before do
|
|
Fabricate(:status, account: user.account, thread: status)
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :context, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #card' do
|
|
it 'returns http success' do
|
|
get :card, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #reblogged_by' do
|
|
before do
|
|
post :reblog, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :reblogged_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'GET #favourited_by' do
|
|
before do
|
|
post :favourite, params: { id: status.id }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :favourited_by, params: { id: status.id }
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|