e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
57 lines
1.6 KiB
Ruby
57 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Api::V1::Timelines::ListController do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:list) { Fabricate(:list, account: user.account) }
|
|
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
context 'with a user context' do
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:lists') }
|
|
|
|
describe 'GET #show' do
|
|
before do
|
|
follow = Fabricate(:follow, account: user.account)
|
|
list.accounts << follow.target_account
|
|
PostStatusService.new.call(follow.target_account, text: 'New status for user home timeline.')
|
|
end
|
|
|
|
it 'returns http success' do
|
|
get :show, params: { id: list.id }
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with the wrong user context' do
|
|
let(:other_user) { Fabricate(:user) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: other_user.id, scopes: 'read') }
|
|
|
|
describe 'GET #show' do
|
|
it 'returns http not found' do
|
|
get :show, params: { id: list.id }
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'without a user context' do
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: nil, scopes: 'read') }
|
|
|
|
describe 'GET #show' do
|
|
it 'returns http unprocessable entity' do
|
|
get :show, params: { id: list.id }
|
|
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
expect(response.headers['Link']).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|