Commit graph

4091 commits

Author SHA1 Message Date
Konrad Pozniak
fe30b6cc85
Merge pull request #3173 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-01-14 19:59:06 +01:00
Nik Clayton
7d444d1f8c
Fix incorrect log message, s/favourite/bookmark/ (#3172) 2023-01-13 20:03:47 +01:00
Mārtiņš Bruņenieks
e68f45058a Translated using Weblate (Latvian)
Currently translated at 80.4% (439 of 546 strings)

Co-authored-by: Mārtiņš Bruņenieks <martinsb@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/lv/
Translation: Tusky/Tusky
2023-01-13 18:59:52 +00:00
xzFantom
1e04973c6a Translated using Weblate (Belarusian)
Currently translated at 100.0% (546 of 546 strings)

Co-authored-by: xzFantom <xzfantom@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/be/
Translation: Tusky/Tusky
2023-01-13 18:59:52 +00:00
Motasem Jouda
ce522489af Translated using Weblate (Arabic)
Currently translated at 100.0% (546 of 546 strings)

Co-authored-by: Motasem Jouda <matsm123@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/ar/
Translation: Tusky/Tusky
2023-01-13 18:59:52 +00:00
Nik Clayton
f28252bfd5
Keep all subclasses of PreferenceFragmentCompat (#3162)
* Mark *PreferencesFragment as @Keep

PreferenceFragment references them by string name, which doesn't work after
ProGuard has obfuscated the code in release mode. The name is no longer
valid and the app crashes.

Fixes https://github.com/tuskyapp/Tusky/issues/3161

* Prefer to keep Preference classes with a Proguard rule

Ensures that all PreferenceFragmentCompat are kept, to prevent the risk
that this could break in a new fragment where `@Keep` is accidentally
omitted.
2023-01-13 19:51:42 +01:00
Nik Clayton
d6e7905e01
Reduce horizontal swipe sensitivity in timelines (#3148)
* Reduce horizontal swipe sensitivity in timelines

Fixes https://github.com/tuskyapp/Tusky/issues/2725, fixes https://github.com/tuskyapp/Tusky/issues/2112, fixes https://github.com/tuskyapp/Tusky/issues/2530, fixes https://github.com/tuskyapp/Tusky/issues/2200, fixes https://github.com/tuskyapp/Tusky/issues/2176, fixes https://github.com/tuskyapp/Tusky/issues/2112, fixes https://github.com/tuskyapp/Tusky/issues/1912, fixes https://github.com/tuskyapp/Tusky/issues/1718, fixes https://github.com/tuskyapp/Tusky/issues/1336

* Set scale factor to 4

* Catch exceptions, just in case
2023-01-13 19:51:09 +01:00
Nik Clayton
e5e076b0d3
Convert BezelImageView, EndlessOnScrollListener, ComposeScheduleView, ProgressImageView to Kotlin (#3147)
* Convert BezelImageView to Kotlin

* Convert EndlessOnScrollListener to Kotlin

* Convert ComposeScheduleView to use view binding

* Convert ComposeScheduleView to Kotlin

* Convert ProgressImageView to Kotlin

* Apply reviewer feedback
2023-01-13 19:49:56 +01:00
Nik Clayton
aa96d02923
Implement HTTP proxy summary as a SummaryProvider (#3091)
* Handle preference fragments using the framework

The previous code started new preference "screens" as activities, even though
each one hosted a single fragment.

Modify this to use the framework's support for swapping in/out different
preference fragments.

PreferencesActivity:
- Remove the code for launching tab and proxy preferences
- Remove the code for setting titles, each fragment is responsible for that
- Implement OnPreferenceStartFragmentCallback to swap fragments in/out with
  the correct animation

PreferencesFragment:
- Use `fragment` property instead of `setOnPreferenceClickListener`
- Set the activity title when resuming

Everything else:
- Set the activity title when resuming

* Implement HTTP proxy summary as a SummaryProvider

Uses the frameworks's support for setting summaries instead of rolling our
own.

Also fix a tiny bug -- the minimum port number to connect to should be 1,
not 0.

* Lint
2023-01-13 19:28:46 +01:00
Nik Clayton
9cf4882f41
Keep scroll position when loading missing statuses (#3000)
* Change "Load more" to load oldest statuses first in home timeline

Previous behaviour loaded missing statuses by using "since_id" and "max_id".
This loads the most recent N statuses, looking backwards from "max_id".

Change to load the oldest statuses first, assuming the user is scrolling
up through the timeline and will want to load statuses in reverse
chronological order.

* Scroll to the bottom of new entries added by "Load more"

- Remember the position of the "Load more" placeholder
- Check the position of inserted entries
- If they match, scroll to the bottom

* Change "Load more" to load oldest statuses first in home timeline

Previous behaviour loaded missing statuses by using "since_id" and "max_id".
This loads the most recent N statuses, looking backwards from "max_id".

Change to load the oldest statuses first, assuming the user is scrolling
up through the timeline and will want to load statuses in reverse
chronological order.

* Scroll to the bottom of new entries added by "Load more"

- Remember the position of the "Load more" placeholder
- Check the position of inserted entries
- If they match, scroll to the bottom

* Ensure the user can't have two simultaneous "Load more" coroutines

Having two simultanous coroutines would break the calculation used to figure
out which item in the list to scroll to after a "Load more" in the timeline.

Do this by:

- Creating a TimelineUiState and associated flow that tracks the "Load more"
  state
- Updating this in the (Cached|Network)TimelineViewModel
- Listening for changes to it in TimelineFragment, and notifying the adapter
- The adapter will disable any placeholder views while "Load more" is active

* Revert changes that loaded the oldest statuses instead of the newest

* Be more robust about locating the status to scroll to

Weirdness with the PagingData library meant that positionStart could still be
wrong after "Load more" was clicked.

Instead, remember the position of the "Load more" item and the ID of the
status immediately after it.

When new items are added, search for the remembered status at the position of
the "Load more" item. This is quick, testing at most LOAD_AT_ONCE items in
the adapter.

If the remembered status is not visible on screen then scroll to it.

* Lint

* Add a preference to specify the reading order

Default behaviour (oldest first) is for "load more" to load statuses and
stay at the oldest of the new statuses.

Alternative behaviour (if the user is reading from top to bottom) is to
stay at the newest of the new statuses.

* Move ReadingOrder enum construction logic in to the enum

* Jump to top if swipe/refresh while preferring newest-first order

* Show a circular progress spinner during "Load more" operations

Remove a dedicated view, and use an icon on the button instead.

Adjust the placeholder attributes and styles accordingly.

* Remove the "loadMoreActive" property

Complicates the code and doesn't really achieve the desired effect. If the
user wants to tap multiple "Load more" buttons they can.

* Update comments in TimelineFragment

* Respect the user's reading order preference if it changes

* Add developer tools

This is for functionality that makes it easier for developers to interact
with the app, or get it in to a known-state.

These features are for use by users, so are only visible in debug builds.

* Adjust how content is loaded based on preferred reading order

- Add the readingOrder to TimelineViewModel so derived classes can use it.
- Update the homeTimeline API to support the `minId` parameter and update
  calls in NetworkTimelineViewModel

In CachedTimelineViewModel:
- Set the bounds of the load to be the status IDs on either side of the
  placeholder ID (update TimelineDao with a new query for this)
- Load statuses using either minId or sinceId depending on the reading order
- Is there was no overlap then insert the new placeholder at the start/end
  of the list depending on reading order

* Lint

* Rename unused dialog parameter to _

* Update API arguments in tests

* Simplify ReadingOrder preference handling

* Fix bug with Placeholder and the "expanded" property

If a status is a Placeholder the "expanded" propery is used to indicate
whether or not it is loading.

replaceStatusRange() set this property based on the old value, and the user's
alwaysOpenSpoiler preference setting.

This shouldn't have been used if the status is a Placeholder, as it can lead
to incorrect loading states.

Fix this.

While I'm here, introduce an explicit computed property for whether a
TimelineStatusEntity is a placeholder, and use that for code clarity.

* Set the "Load more" button background to transparent

* Fix typo.

* Inline spec, update comment

* Revert 1480c6aa3ac5c0c2d362fb271f47ea2259ab14e2

Turns out the behaviour is not desired.

* Remove unnecessary Log call

* Extract function

* Change default to newest first
2023-01-13 19:26:24 +01:00
Jake Wharton
c4d569314f
Remove old opt-in for RequiresOptIn (#3167)
As of Kotlin 1.7 the opt-in feature is now stable and does not need an explicit declaration.

https://kotlinlang.org/docs/whatsnew17.html#stable-opt-in-requirements
2023-01-12 19:41:35 +01:00
Konrad Pozniak
9abf1e5e33
prevent thread view from scrolling when post is interacted with (#3164)
* prevent thread view from scrolling when post is interacted with

* fix ktlint
2023-01-12 19:41:07 +01:00
Konrad Pozniak
98eb324aa0
Fix media preview bugs (#3160)
* fix media preview layout issues

* make sure "ALT" label is never shown when media preview is hidden
2023-01-12 19:40:51 +01:00
Konrad Pozniak
865ba5909f
Merge pull request #3155 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-01-12 19:40:38 +01:00
Nik Clayton
5498386be1
Respect "Always expand posts marked with content warnings" pref in notifications (#3154)
Fixes https://github.com/tuskyapp/Tusky/issues/3139
2023-01-12 19:40:01 +01:00
XoseM
ad59ae9b3f Translated using Weblate (Galician)
Currently translated at 100.0% (546 of 546 strings)

Co-authored-by: XoseM <xosem@disroot.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/gl/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Jan Lindblom
de74d06836 Translated using Weblate (Swedish)
Currently translated at 100.0% (546 of 546 strings)

Co-authored-by: Jan Lindblom <janlindblom@fastmail.fm>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/sv/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Newidyn
f4f6abc8f2 Translated using Weblate (Welsh)
Currently translated at 100.0% (546 of 546 strings)

Co-authored-by: Newidyn <grugallt@protonmail.ch>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
xzFantom
57bc55b03d Translated using Weblate (Belarusian)
Currently translated at 98.5% (538 of 546 strings)

Translated using Weblate (Belarusian)

Currently translated at 90.4% (494 of 546 strings)

Translated using Weblate (Belarusian)

Currently translated at 81.1% (438 of 540 strings)

Translated using Weblate (Belarusian)

Currently translated at 77.2% (417 of 540 strings)

Co-authored-by: xzFantom <xzfantom@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/be/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Hồ Nhất Duy
0fecd230d3 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (546 of 546 strings)

Translated using Weblate (Vietnamese)

Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Hồ Nhất Duy <mastoduy@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Manuel
ef506a28ce Translated using Weblate (Italian)
Currently translated at 98.1% (530 of 540 strings)

Co-authored-by: Manuel <mannivuwiki@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Mārtiņš Bruņenieks
eceb47e2f8 Translated using Weblate (Latvian)
Currently translated at 79.6% (435 of 546 strings)

Translated using Weblate (Latvian)

Currently translated at 75.0% (410 of 546 strings)

Translated using Weblate (Latvian)

Currently translated at 72.9% (394 of 540 strings)

Translated using Weblate (Latvian)

Currently translated at 62.4% (337 of 540 strings)

Co-authored-by: Mārtiņš Bruņenieks <martinsb@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/lv/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Ihor Hordiichuk
77b91b2e1f Translated using Weblate (Ukrainian)
Currently translated at 100.0% (546 of 546 strings)

Translated using Weblate (Ukrainian)

Currently translated at 100.0% (540 of 540 strings)

Translated using Weblate (Ukrainian)

Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/uk/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Eric
59b456cec1 Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (546 of 546 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (540 of 540 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Eric <alchemillatruth@purelymail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/zh_Hans/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Quentí
58e90661ed Translated using Weblate (Occitan)
Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Quentí <quentinantonin@free.fr>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/oc/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Rhoslyn Prys
759ca4faf0 Translated using Weblate (Welsh)
Currently translated at 100.0% (546 of 546 strings)

Translated using Weblate (Welsh)

Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Rhoslyn Prys <post@meddal.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-01-12 18:36:12 +00:00
Nik Clayton
8eb195cff6
Enable robolectric logging (#3143)
Robolectric normally swallows output from `Log.*` calls in tests and
the code under test. This can make debugging failing tests more
difficult than it needs to be.

Set `robolectric.logging.enabled` to `true` to enable the logs.
2023-01-12 19:10:11 +01:00
Nik Clayton
561eda8482
Remove rxjava from deletestatus API (#3041)
* Remove rxjava from API calls used by AccountListFragment

* Remove rxjava from API calls used by AccountViewModel::changeRelationship()

The affected API functions are also called from

- ReportViewModel.kt
- SearchViewModel.kt
- AccountListFragment.kt
- SFragment.java
- TimelineCases.kt

so they have also been updated.

This change requires bridging from Java code to Kotlin `suspend` functions,
by creating wrappers for the `mute` and `block` functions that can be
called from Java and create a coroutine scope.

I've deliberately made this fairly ugly so that it sticks out and can be
removed later.

* Use "Throwable" type and name

* Delete 46.json

Not sure where this came from.

* Remove rxjava from the deleteStatus call path

* Emit log messages with the correct tag

* Add another log tag, and lint

* Use TAG in log messages now it's present

* Lint

* Move viewModelScope.launch in to changeRelationshop()

* Use onSuccess/onFailure pair instead of fold

* Return Deferred when deleting statuses
2023-01-10 21:20:00 +01:00
Nik Clayton
c650ca9362
Improve the actual and perceived speed of thread loading (#3118)
* Improve the actual and perceived speed of thread loading

To improve the actual speed, note that if the user has opened a thread from
their home timeline then the initial status is cached in the database. Other
statuses in the same thread may be cached as well.

So try and load the initial status from the database, falling back to the
network if it's not present (e.g., the user has opened a thread from the
local or federated timelines, or a search).

Introduce a new loading state to deal with this case.

In typical cases this allows the UI to display the initial status immediately
with no need to show a progress indicator.

To improve the perceived speed, delay showing the initial loading circular
progress indicators by 500ms. If loading the initial status completes within
that time no spinner is shown and the user will perceive the action as
close-to-immediate
(https://www.nngroup.com/articles/response-times-3-important-limits/).

Additionally, introduce an extra indeterminate progress indicator.

The new indicator is linear, anchored to the bottom of the screen, and shows
progress loading ancestor/descendant statuses. Like the other indicator is
also delayed 500ms from when ancestor/descendant status information is
fetched, and if the fetch completes in that time it will not be shown.

* Mark `getStatus` as suspend so it doesn't run on the main thread

* Save an allocation, use an isDetailed parameter to TimelineStatusWithAccount.toViewData

Rename Status.toViewData's "detailed" parameter to "isDetailed" for
consistency with other uses.

* Ensure suspend functions run to completion when testing

* Delay-load the status from the network even if it's cached

This speeds up the UI while ensuring it will eventually contain accurate data
from the remote.

* Load the network status before updating the list

Avoids excess animations if the network copy has changes

* Fix UI flicker when loading reblogged statuses

* Lint

* Fixup tests
2023-01-09 21:31:31 +01:00
Nik Clayton
d645416028
Show a close button for hashtag tab chips (#3140)
The intent of the previous code seems to be to show an "X" icon on a hashtag
chip when two or more chips are present.

This didn't work because the icon was not set as visible.

Fix this. In addition, set this as a "cancel" icon, not the chip's regular
icon, so it appears on the right (in LTR locales), as is normal for the
close button on chips.

Tinting the icon did nothing, so remove that.
2023-01-09 21:24:37 +01:00
Konrad Pozniak
95631069b8
don't crash on unparseable date (#3129) 2023-01-09 21:24:04 +01:00
mcclure
59fb710f64
Share and copy menu items for account page (#3120)
* Share and copy menu items for account page (first attempt)]

* Always include domain in username in 'handle' copy

* Remove profile copy options, rename 'handle' to 'username'

* Long press on username in profile to copy it to clipboard

* Changes for code review: localUsername not username, Snackbar not Toast

* Do not trust getDomain() when getting full username. This means full-username build has to happen in AccountActivity instead of Account

* Replace != null -> \!\! idiom with more kotlin-y (and more threadsafe) ?.let pattern

* Unnecessary import

* Comment clarifying safety of \!\!
2023-01-09 21:08:46 +01:00
Levi Bard
8ca92d9fde
Add new mastodon status url format to looksLikeMastodonUrl. (#3136)
Fixes #3092
2023-01-09 21:07:22 +01:00
Constantin A
ca01776847
Update FilemojiCompat to version 3.2.7 (#3151) 2023-01-09 21:06:47 +01:00
Nik Clayton
0328c4e876
Convert "title case" strings to "sentence case" (#3132)
Tusky mostly uses (correctly, per Android style guide) sentence case (i.e.,
a single initial capital letter) in strings like "Scheduled posts" or
"Muted users".

But there are a few instances of title case (i.e., each initial letter is
capitalised) that have crept in ("Account Preferences", "Log Out",
"Follow Requests", etc).

Convert them to sentence case.
2023-01-03 21:07:04 +01:00
Konrad Pozniak
eb02d0b6ce
Merge pull request #3128 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-01-02 17:34:58 +01:00
Manuel
ee2309cee8 Translated using Weblate (Italian)
Currently translated at 100.0% (540 of 540 strings)

Co-authored-by: Manuel <mannivuwiki@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Weblate
8602337aae Update translation files
Updated by "Cleanup translation files" hook in Weblate.

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Hồ Nhất Duy
35ef723286 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Hồ Nhất Duy <mastoduy@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Ihor Hordiichuk
753d551d95 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/uk/
Translation: Tusky/Tusky
2023-01-02 16:01:35 +00:00
Eric
5cdfca7b04 Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Eric <alchemillatruth@purelymail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/zh_Hans/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Manuel
ff9ad0d1fc Translated using Weblate (Italian)
Currently translated at 99.4% (535 of 538 strings)

Co-authored-by: Manuel <manueltassi91@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Andrés Blasco Arnáiz
e104b5731f Translated using Weblate (Spanish)
Currently translated at 100.0% (538 of 538 strings)

Co-authored-by: Andrés Blasco Arnáiz <andresbarnaiz@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/es/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Newidyn
827ee2188a Translated using Weblate (Welsh)
Currently translated at 98.7% (533 of 540 strings)

Translated using Weblate (Welsh)

Currently translated at 99.4% (535 of 538 strings)

Co-authored-by: Newidyn <grugallt@protonmail.ch>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-01-02 16:01:34 +00:00
Conny Duck
468f8f1b14 use MaterialColors.getColor instead of ThemeUtils (fixes build) 2023-01-02 14:36:07 +01:00
Konrad Pozniak
33e4da7abb
Improve muted users list (#3127)
* migrate MutesAdapter to viewbinding

* migrate item_muted_user to ConstraintLayout

* add switch instead of button

* change unmute button position

* delete unused string
2023-01-02 14:09:40 +01:00
Konrad Pozniak
61a45ae376
show status edits (#3049)
* show status edits part 1

* show status edits part 2 - load status edits

* fix code formatting

* add dialog to show status edits

* small improvements

* use ALIGN_CENTER to position status visibility icon when possible

* rename status_timestamp_info view to status_meta_info

* make dateFormat static

* remove commented-out code

* move edits to dedicated fragment
2023-01-02 14:09:18 +01:00
Konrad Pozniak
8c0f02cf33
Merge pull request #3109 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2022-12-31 13:08:05 +01:00
Nik Clayton
a5f479d79c
Fix saving changes to statuses when editing (#3103)
* Fix saving changes to statuses when editing

With the previous code backing out of a status editing operation where changes
had been made  (whether it was editing an existing status, a scheduled status,
or a draft) would prompt the user to save the changes as a new draft.

See https://github.com/tuskyapp/Tusky/issues/2704 and
https://github.com/tuskyapp/Tusky/issues/2705 for more detail.

The fix:

- Create an enum to represent the four different kinds of edits that can
  happen
  - Editing a new status (i.e., composing it for the first time)
  - Editing a posted status
  - Editing a draft
  - Editing a scheduled status

- Store this in ComposeOptions, and set it appropriately everywhere
  ComposeOptions is created.

- Check the edit kind when backing out of ComposeActivity, and use this to
  show one of three different dialogs as appropriate so the user can:
  - Save as new draft or discard changes
  - Continue editing or discard changes
  - Update existing draft or discard changes

Also fix ComposeViewModel.didChange(), which erroneously reported false if the
old text started with the new text (e.g., if the old text was "hello, world"
and it was edited to "hello", didChange() would not consider that to be a
change).

Fixes https://github.com/tuskyapp/Tusky/issues/2704,
https://github.com/tuskyapp/Tusky/issues/2705

* Use orEmpty extension function
2022-12-31 13:04:49 +01:00
Nik Clayton
2e72fa0dfc
Handle preference fragments using the framework (#3090)
* Handle preference fragments using the framework

The previous code started new preference "screens" as activities, even though
each one hosted a single fragment.

Modify this to use the framework's support for swapping in/out different
preference fragments.

PreferencesActivity:
- Remove the code for launching tab and proxy preferences
- Remove the code for setting titles, each fragment is responsible for that
- Implement OnPreferenceStartFragmentCallback to swap fragments in/out with
  the correct animation

PreferencesFragment:
- Use `fragment` property instead of `setOnPreferenceClickListener`
- Set the activity title when resuming

Everything else:
- Set the activity title when resuming

* Lint

* Use the commit extension function
2022-12-31 13:02:23 +01:00